Configurable upstream timeouts #85
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new annotations got the priority, the simple 'timeout' annotation still sets the 3 timeouts but if there is, at least one of the new ones, it's overwriting the values set by the simple annotation.
Applying @Aluxima suggestion Co-authored-by: Laurent Marchaud <[email protected]>
|
@mmcgarr hello, any news on this issue ? :) |
|
Hi @Aluxima thanks for making this change! Can you just rebase on master and I'll be able to get this merged in 🙏 |
mmcgarr
reviewed
Jan 17, 2025
| @@ -1,3 +1,7 @@ | |||
| bin/ | |||
| command | |||
| testing | |||
| ca/ | |||
| config/ | |||
| envoy/ | |||
There was a problem hiding this comment.
This ignores all directories called envoy, including pkg/envoy/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this feature adds the possibility to customize specific upstream timeouts, both with default values and via ingress annotations.
This brings no breaking change, the old
timeoutparameter still has the same behavior.Thanks :)