Skip to content

Commit

Permalink
comment: TODO 제거
Browse files Browse the repository at this point in the history
  • Loading branch information
wonslee committed Feb 13, 2024
1 parent cffb599 commit d4eb1af
Show file tree
Hide file tree
Showing 4 changed files with 1 addition and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@ public class EvaluatePost extends BaseTimeEntity {
@Column(columnDefinition = "TEXT", nullable = false)
private String content; //주관적인 강의평가 입력내용

// TODO: 연관관계 편의 메서드로 대체
public void setLecture(Lecture lecture) {
this.lecture = lecture;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ public class Lecture extends BaseTimeEntity {
@GeneratedValue(strategy = GenerationType.IDENTITY)
private Long id;

// TODO refactor: Embeddable 객체로 분리
@Column(name = "semester_list")
private String semester;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,9 @@ public class BuildEmailAuthForm {
private static final String CONFIRMATION_TOKEN_URL = "/v2/confirmation-token/verify/?token=";
private final ServerProperties serverProperties;

// TODO: refactor static 메서드 고민. serverProperties를 외부에서 주입받아야 함
public String buildEmail(ConfirmationToken confirmationToken) {
String redirectUrl = buildRedirectUrl(confirmationToken);

// TODO refactor: 반복성 제거. 템플릿 메서드 패턴 혹은 타임 리프 고민
return "<center>\n" +
"\t<img class=\"suwikilogo\"src=\"https://avatars.githubusercontent.com/u/96416159?s=200&v=4\" style=\"display:block; \"alt=\"SUWIKILOGO\">"
+
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,12 @@
public final class USWTermResolver {
private static final String[] KEYWORDS_TO_REMOVE = {"재수강", "비대면수업", "대면수업", "혼합수업"};

// TODO refactor: REGEX 검사
// 변환에 필요한 최소한의 스트링 형식입니다.
// 해당 형식에 맞지 않는다면 수원대측에서 형식을 바꾼 것이므로 더 이상 호환되지 않기 때문에 예외를 발생시키고 적재를 중단해야 합니다.
// https://regexr.com/7rq1g
// https://regexr.com/7rq1g "^([\\s가-힣A-Za-z\\d-]+\\([월화수목금토일]\\d+(?:,\\d+)*.*?\\))+$"
// pass : "강의실107-1(수6,7,8)" "강의실 B215(화5,6,7 수5,6,7)"
// pass : "(월1,2)" -> "미정(월1,2)"
// fail : "강의실(1,2)" "강의실 월1,2" "강의실107(요일아님6,7,8)" "요일없음(1,2)" "강의실103(화5,6),강의실103"
// private static final String PLACE_SCHEDULE_REGEX = "^([\\s가-힣A-Za-z\\d-]+\\([월화수목금토일]\\d+(?:,\\d+)*.*?\\))+$";

private static final String ESTABLISHED_YEAR = "subjtEstbYear";
private static final String ESTABLISHED_SEMESTER = "subjtEstbSmrCd";
Expand Down

0 comments on commit d4eb1af

Please sign in to comment.