Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

10408: Add Special Session Copy Notes to Trial Sessions Page #5486

Draft
wants to merge 24 commits into
base: staging
Choose a base branch
from

Conversation

JayFlexy
Copy link
Contributor

@JayFlexy JayFlexy commented Oct 24, 2024

See 10408 Ticket

Screenshot 2024-10-24 at 6 20 21 PM

Updated Screenshot:
Screenshot 2024-10-31 at 4 29 13 PM

Example with Excessive notes:
Screenshot 2024-11-01 at 5 11 02 PM

TODO

  • Tests
  • Slide session copy notes over to align under location as seen in the ticket

@JayFlexy JayFlexy changed the title 10408 story 10408: Add Special Session Copy Notes to Trial Sessions Page Oct 25, 2024
Copy link
Contributor

@zachrog zachrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already chatted about it but I am just requesting changes to how session copy notes are being fetched from Promise.all() -> batchGet as there are currently ~500 special trial sessions in prod.

@JayFlexy JayFlexy marked this pull request as ready for review November 4, 2024 17:27
@JayFlexy JayFlexy dismissed zachrog’s stale review November 4, 2024 17:56

Addressed changes, also having baby at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants