-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
10408: Add Special Session Copy Notes to Trial Sessions Page #5486
Draft
JayFlexy
wants to merge
24
commits into
ustaxcourt:staging
Choose a base branch
from
flexion:10408-story
base: staging
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mwindo
reviewed
Oct 24, 2024
Mwindo
reviewed
Oct 24, 2024
web-client/src/views/TrialSessionWorkingCopy/TrialSessionWorkingCopy.tsx
Outdated
Show resolved
Hide resolved
zachrog
reviewed
Oct 25, 2024
shared/src/proxies/trialSessions/getBulkSpecialTrialSessionCopyNotesProxy.ts
Outdated
Show resolved
Hide resolved
zachrog
reviewed
Oct 25, 2024
web-api/src/business/useCases/trialSessions/getBulkTrialSessionCopyNotesInteractor.ts
Outdated
Show resolved
Hide resolved
zachrog
reviewed
Oct 25, 2024
web-api/src/lambdas/trialSessions/getBulkTrialSessionCopyNotesLambda.ts
Outdated
Show resolved
Hide resolved
zachrog
reviewed
Oct 25, 2024
web-client/src/presenter/actions/TrialSession/getBulkSpecialTrialSessionCopyNotesAction.ts
Outdated
Show resolved
Hide resolved
JayFlexy
changed the title
10408 story
10408: Add Special Session Copy Notes to Trial Sessions Page
Oct 25, 2024
zachrog
previously requested changes
Oct 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Already chatted about it but I am just requesting changes to how session copy notes are being fetched from Promise.all() -> batchGet as there are currently ~500 special trial sessions in prod.
JayFlexy
dismissed
zachrog’s stale review
November 4, 2024 17:56
Addressed changes, also having baby at the moment.
codyseibert
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See 10408 Ticket
Updated Screenshot:
Example with Excessive notes:
TODO
TestsSlide session copy notes over to align under location as seen in the ticket