10074 bug: Auto Scroll Issues on Petitions Clerk Create Case Form (and more) -- Updates #5419
Conversation
…oked spots; fix error messaging in editing a practitioner; fix custom case report live validation
…ssociation request issue
| .description('The first name of the practitioner.') | ||
| .messages({ | ||
| '*': 'Enter first name', | ||
| }), | ||
| lastName: JoiValidationConstants.STRING.max(100) | ||
| .required() | ||
| .description('The last name of the practitioner.'), | ||
| .description('The last name of the practitioner.') | ||
| .messages({ | ||
| '*': 'Enter last name', | ||
| }), |
There was a problem hiding this comment.
Otherwise, this will say, e.g., "firstname" is required
| @@ -18,11 +18,9 @@ export const filingPartiesFormHelper = ( | |||
| PARTY_TYPES, | |||
| } = applicationContext.getConstants(); | |||
|
|
|||
| const partyValidationError = | |||
| const partyValidationCheckboxError = | |||
There was a problem hiding this comment.
We were displaying the validationErrors.otherFilingParty twice, once in the general form and again in the nested child form. We now just show it in the latter.
| @@ -10,7 +11,7 @@ export const validateAddPractitionerSequence = [ | |||
| validate: [ | |||
| validateAddPractitionerAction, | |||
| { | |||
| error: [setValidationErrorsAction], | |||
| error: [setValidationErrorsAction, setValidationAlertErrorsAction], | |||
There was a problem hiding this comment.
Sync the error banner with the validation errors.
There was a problem hiding this comment.
This happens in a few other places in this PR.
| import { shouldValidateAction } from '@web-client/presenter/actions/shouldValidateAction'; | ||
| import { validateCustomCaseReportFiltersAction } from '@web-client/presenter/actions/validateCustomCaseReportFiltersAction'; | ||
|
|
||
| export const validateCustomCaseReportSequence = [ |
There was a problem hiding this comment.
The custom case report wasn't live validating.
| @@ -77,7 +75,7 @@ export const StartCaseInternal = connect( | |||
| > | |||
| <div className="blue-container"> | |||
| <IRSNotice | |||
| validateFormData={validateCaseDetailSequence} | |||
| validateFormData={validatePetitionFromPaperSequence} | |||
There was a problem hiding this comment.
We're using this everywhere else in this component, and I saw no good reason for the mismatch. Instead, it led to errors not syncing correctly in the ErrorNotification banner,
10074 became "fix a bunch of validation quirks." (See original PR.) UX discovered a few other validation quirks that this PR addresses.