-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
10501 Bugfix: Fix judges chambers not populating in certain message modals #5393
Merged
jtdevos
merged 6 commits into
ustaxcourt:test
from
flexion:hotfix-judges-chambers-in-document-qc-message-intermediate-branch-to-test-1727103429
Sep 23, 2024
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
882b4c3
add getJudgesChambersSequence to openCompleteAndSendMessageModalSequence
Mwindo 686a22f
also add to openForwardMessageModalSequence
Mwindo 747e112
Merge branch 'test' of https://github.com/ustaxcourt/ef-cms into hotf…
Mwindo 13102ad
10501-bug: add tests
Mwindo 821207d
10501-bug: update tests after discovering the forward message test co…
Mwindo f063811
10501-bug: no good reason to set messageToForwardSubject in the befor…
Mwindo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
70 changes: 70 additions & 0 deletions
70
cypress/local-only/tests/integration/messages/chambers-dropdown.cy.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,70 @@ | ||
// make sure the chambers dropdown works in open message, qc, and forward | ||
|
||
import { | ||
createMessage, | ||
enterSubject, | ||
fillOutMessageField, | ||
forwardMessage, | ||
goToDocumentNeedingQC, | ||
openCompleteAndSendMessageDialog, | ||
selectChambers, | ||
selectRecipient, | ||
selectSection, | ||
sendMessage, | ||
} from '../../../support/pages/document-qc'; | ||
import { goToCase } from '../../../../helpers/caseDetail/go-to-case'; | ||
import { loginAsDocketClerk } from '../../../../helpers/authentication/login-as-helpers'; | ||
import { v4 } from 'uuid'; | ||
|
||
describe('BUG: chambers dropdown should be populated in message modals', () => { | ||
const chambersSection = 'buchsChambers'; | ||
const recipient = 'Judge Buch'; | ||
const caseNumber = '103-20'; | ||
const messageToForwardSubject = v4(); | ||
|
||
before(() => { | ||
// Send a message that we will forward later. | ||
// We do this here rather than in the message forward test itself because | ||
// judgesChambers are cached, so the message forward test could | ||
// "pass" when it shouldn't if we create a message (and populate cache) first. | ||
loginAsDocketClerk(); | ||
goToCase(caseNumber); | ||
createMessage(); | ||
selectSection('Docket'); | ||
selectRecipient('Test Docketclerk'); | ||
enterSubject(messageToForwardSubject); | ||
fillOutMessageField(); | ||
sendMessage(); | ||
}); | ||
|
||
it('should have nonempty chambers section in create new message modal', () => { | ||
loginAsDocketClerk(); | ||
goToCase(caseNumber); | ||
createMessage(); | ||
|
||
selectSection('Chambers'); | ||
selectChambers(chambersSection); | ||
selectRecipient(recipient); | ||
}); | ||
|
||
it('should have nonempty chambers sections in forward message modal', () => { | ||
loginAsDocketClerk(); | ||
goToCase(caseNumber); | ||
forwardMessage(messageToForwardSubject); | ||
|
||
selectSection('Chambers'); | ||
selectChambers(chambersSection); | ||
selectRecipient(recipient); | ||
}); | ||
|
||
it('should have nonempty chambers sections in docket QC complete and send message modal', () => { | ||
cy.login('docketclerk', '/document-qc/section/inbox'); | ||
cy.get('.big-blue-header').should('exist'); | ||
goToDocumentNeedingQC(); | ||
openCompleteAndSendMessageDialog(); | ||
|
||
selectSection('Chambers'); | ||
selectChambers(chambersSection); | ||
selectRecipient(recipient); | ||
}); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 2 additions & 0 deletions
2
web-client/src/presenter/sequences/openForwardMessageModalSequence.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,13 @@ | ||
import { clearModalStateAction } from '../actions/clearModalStateAction'; | ||
import { getJudgesChambersSequence } from '@web-client/presenter/sequences/getJudgesChambersSequence'; | ||
import { getMostRecentMessageInThreadAction } from '../actions/getMostRecentMessageInThreadAction'; | ||
import { setForwardMessageModalDialogModalStateAction } from '../actions/WorkItem/setForwardMessageModalDialogModalStateAction'; | ||
import { setShowModalFactoryAction } from '../actions/setShowModalFactoryAction'; | ||
|
||
export const openForwardMessageModalSequence = [ | ||
clearModalStateAction, | ||
getMostRecentMessageInThreadAction, | ||
getJudgesChambersSequence, | ||
setForwardMessageModalDialogModalStateAction, | ||
setShowModalFactoryAction('ForwardMessageModal'), | ||
]; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a huge deal, but I will remove this comment for the staging branch