Bugfix: Do not attempt to sign user out if clientNeedsToRefresh is true #5378
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into an error today on test. I had two tabs open:
This PR is effectively an imperfect patch. A stale client should avoid sending any backend request, otherwise we will broadcast to other tabs that they need to refresh. (Alternatively, we can choose not to broadcast, but that feels like the less-good, less-user-friendly, more convenient solution. Alternatively alternatively, upon getting a "need to refresh" broadcast message, a tab could ping for a backend health check.) I don't believe we have any other "background tab" requests being sent to the back end at this time.
This was something I should have caught as part of my work on 10349, but I was focused on idle logout at the expense of user-initiated logout.