10463 Bug: update telephone input elements #5263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r input elements so that users can write "N/A" as instructed on mobile, if necessary
Mwindo
approved these changes
Aug 20, 2024
There was a problem hiding this comment.
Is it worth getting rid of the styling in forms.scss? Anyway, this fix makes sense to me. Thank you!
Thank you for catching that: there are no longer any |
nechama-krigsman
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change type attribute from
teltotextfor phone number input elements so that users can write "N/A" as instructed on mobile, if necessary.Using
type="tel"does not introduce validation as withemailorurl. As far as I can tell, the key difference between atelinput element and atextone is that mobile users are directed to a numbers-only keyboard in the case of the former. Since this is the behavior we want to change,type="text"should work.