Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDFParseError alarm #5257

Open
wants to merge 1 commit into
base: test
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ export const parseAndScrapePdfContents = async ({
view[i] = pdfBuffer[i];
}

// TODO: Wait to hear from Jessica on what should happen for PDF scraping failures
try {
return await applicationContext
.getUtilities()
Expand Down
4 changes: 2 additions & 2 deletions web-api/terraform/modules/api/alarms.tf
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ resource "aws_cloudwatch_log_metric_filter" "pdf_parse_error_filter" {
pattern = "\"Failed to parse PDF\""

metric_transformation {
name = "PDFParseErrors"
name = "PDFParseErrors_${var.environment}_${var.current_color}"
namespace = "EFCMS"
value = "1"
}
Expand All @@ -22,4 +22,4 @@ resource "aws_cloudwatch_metric_alarm" "pdf_parse_error_alarm" {
threshold = "1"

alarm_actions = [var.alert_sns_topic_arn]
}
}
Loading