10309 Opex: Fix MaxListenersExceededWarning #5244
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
app.ts
andapp-public.ts
, we run the logging middleware viaapp.use(logger())
. However, the waylogger
is set up means that we are re-creating our logger--and re-adding related event listeners--on every request. This quickly leads to aMaxListenersExceededWarning
(for instance, just refresh the page a few times). This PR fixes the issue by using a closure to create the logger once at app initialization rather than once per request.