10349 bug intermediate branch to test 1722427896 #5198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e alert modal bug and the infinite spinning wheel bug
…n sign out to avoid the modal appearing when no user is signed in
…t app behavior, and fixing a few typos
… to see if the cerebral update to constants is actually working in CI
…video artifacts suggest modal is not appearing
…o toggle instance management from cypress; tests *should* pass in CI now, if done correctly
… which tests fail
…anecdotally, like page sometimes does not initially load), and only run one integration test
…loading before the sign out and therefore stuck on pre-signout modal being shown
…sole.log, remove outdated comment
…9-bug-intermediate-branch-to-test-1722427896
| signOutSequence: signOutSequence as unknown as Function, | ||
| signOutUserInitiatedSequence: | ||
| signOutUserInitiatedSequence as unknown as Function, |
There was a problem hiding this comment.
Can this sequence be typed instead of as unknown as Function?
There was a problem hiding this comment.
Ah, yes, thank you! I typed the other sequence but forgot to type this one.
nechama-krigsman
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #5176