breaking out event-codes-by-year into -count-non-stricken-event-codes #5180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimlerza
reviewed
Jul 24, 2024
jimlerza
requested changes
Jul 24, 2024
- now using node:util:parseArgs instead of doing it manual - pulled out parsing numbers, ranges from count-event-codes-by-year into a reportUtils file - added exec shebang so count-event-codes can be run directly - todo: similarly refactor event-codes-by-year
jimlerza
approved these changes
Aug 5, 2024
zachrog
approved these changes
Sep 4, 2024
Mwindo
approved these changes
Sep 6, 2024
| }: { | ||
| applicationContext: ServerApplicationContext; | ||
| eventCodes: string[]; | ||
| onlyNonStricken: boolean; |
There was a problem hiding this comment.
Any reason not to make this includeStricken as below?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…-by-year