PDFParseError: make alarm metric env and color specific

ustaxcourt · Aug 16, 2024 · f51de24 · f51de24
1 parent cb3a59d
commit f51de24
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/web-api/src/business/useCaseHelper/pdf/parseAndScrapePdfContents.ts b/web-api/src/business/useCaseHelper/pdf/parseAndScrapePdfContents.ts
@@ -21,7 +21,6 @@ export const parseAndScrapePdfContents = async ({
     view[i] = pdfBuffer[i];
   }
 
-  // TODO: Wait to hear from Jessica on what should happen for PDF scraping failures
   try {
     return await applicationContext
       .getUtilities()

diff --git a/web-api/terraform/modules/api/alarms.tf b/web-api/terraform/modules/api/alarms.tf
@@ -5,7 +5,7 @@ resource "aws_cloudwatch_log_metric_filter" "pdf_parse_error_filter" {
   pattern        = "\"Failed to parse PDF\""
 
   metric_transformation {
-    name      = "PDFParseErrors"
+    name      = "PDFParseErrors_${var.environment}_${var.current_color}"
     namespace = "EFCMS"
     value     = "1"
   }
@@ -22,4 +22,4 @@ resource "aws_cloudwatch_metric_alarm" "pdf_parse_error_alarm" {
   threshold           = "1"
 
   alarm_actions = [var.alert_sns_topic_arn]
-}
+}