10409: Add filtering for unassigned judges

ustaxcourt · Sep 5, 2024 · f4be15c · f4be15c
1 parent e3ba313
commit f4be15c
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 4 deletions.
diff --git a/web-client/src/presenter/computeds/trialSessionsHelper.test.ts b/web-client/src/presenter/computeds/trialSessionsHelper.test.ts
@@ -228,6 +228,27 @@ describe('trialSessionsHelper', () => {
         expect(trialSessionsOnly.length).toEqual(1);
       });
 
+      it('should only show trial sessions who do not have a judge when the judge filter is "unassigned"', () => {
+        trialSession1.judge = undefined;
+        trialSession2.judge!.userId = '2';
+        trialSessionsPageState.trialSessions = [trialSession1, trialSession2];
+        trialSessionsPageState.filters.judgeId = 'unassigned';
+
+        const result = runCompute(trialSessionsHelper, {
+          state: {
+            permissions: getUserPermissions(docketClerk1User),
+            trialSessionsPage: trialSessionsPageState,
+          },
+        });
+
+        const trialSessionsOnly =
+          result.trialSessionRows.filter(isTrialSessionRow);
+        expect(trialSessionsOnly.length).toEqual(1);
+        expect(trialSessionsOnly[0].trialSessionId).toEqual(
+          trialSession1.trialSessionId,
+        );
+      });
+
       it('should not filter trial sessions by judge when judge filter is All', () => {
         trialSessionsPageState.trialSessions = [trialSession1, trialSession2];
         trialSessionsPageState.filters.judgeId = 'All';

diff --git a/web-client/src/presenter/computeds/trialSessionsHelper.ts b/web-client/src/presenter/computeds/trialSessionsHelper.ts
@@ -43,6 +43,7 @@ export const trialSessionsHelper = (
     })
     .filter(trialSession => {
       if (filters.judgeId === 'All') return true;
+      if (filters.judgeId === 'unassigned') return !trialSession.judge?.userId;
       return trialSession.judge?.userId === filters.judgeId;
     })
     .filter(trialSession => {

diff --git a/web-client/src/views/TrialSessions/TrialSessions.tsx b/web-client/src/views/TrialSessions/TrialSessions.tsx
@@ -178,6 +178,7 @@ const TrialSessionFilters = connect(
             <select
               aria-label="location"
               className="usa-select select-left width-180 inline-select"
+              value={trialSessionsPage.filters.trialLocation}
               onChange={e => {
                 setTrialSessionsFiltersSequence({
                   trialLocation: e.target.value,
@@ -192,6 +193,7 @@ const TrialSessionFilters = connect(
               className="usa-select select-left width-180 inline-select margin-left-1pt5rem"
               id="proceedingFilter"
               name="proceedingType"
+              value={trialSessionsPage.filters.proceedingType}
               onChange={e => {
                 setTrialSessionsFiltersSequence({
                   proceedingType: e.target.value as TrialSessionProceedingType,
@@ -212,6 +214,7 @@ const TrialSessionFilters = connect(
               className="usa-select select-left width-180 inline-select margin-left-1pt5rem"
               id="sessionFilter"
               name="sessionType"
+              value={trialSessionsPage.filters.sessionType}
               onChange={e => {
                 setTrialSessionsFiltersSequence({
                   sessionType: e.target.value,
@@ -230,6 +233,7 @@ const TrialSessionFilters = connect(
               className="usa-select select-left width-180 inline-select margin-left-1pt5rem"
               id="judgeFilter"
               name="judge"
+              value={trialSessionsPage.filters.judgeId}
               onChange={e => {
                 setTrialSessionsFiltersSequence({
                   judgeId: e.target.value,
@@ -244,10 +248,7 @@ const TrialSessionFilters = connect(
               ))}
 
               {trialSessionsHelper.showUnassignedJudgeFilter && (
-                <option
-                  key={trialSessionsHelper.trialSessionJudges.length}
-                  value="unassigned"
-                >
+                <option key="unassigned" value="unassigned">
                   Unassigned
                 </option>
               )}