10455-story: adding validation to ScanBatchPreview uploader and updat…

…ing tests
ustaxcourt · Sep 5, 2024 · f268df6 · f268df6
1 parent d264534
commit f268df6
Show file tree

Hide file tree

Showing 28 changed files with 163 additions and 57 deletions.
diff --git a/cypress/helpers/caseDetail/docketRecord/paperFiling/create-and-serve-paper-filing.ts b/cypress/helpers/caseDetail/docketRecord/paperFiling/create-and-serve-paper-filing.ts
@@ -18,6 +18,7 @@ export function createAndServePaperFiling(
   attachFile({
     filePath: '../../helpers/file/sample.pdf',
     selector: 'input#primaryDocumentFile-file',
+    selectorToAwaitOnSuccess: '[data-testid="remove-pdf"]',
   });
 
   cy.get('[data-testid="save-and-serve"]').click();

diff --git a/cypress/helpers/file/upload-file.ts b/cypress/helpers/file/upload-file.ts
@@ -15,16 +15,16 @@ export function uploadFile(testId: string) {
 }
 
 export function attachFile({
-  awaitSuccess = true,
   filePath,
   selector,
+  selectorToAwaitOnSuccess = '[data-testid^="upload-file-success"]',
 }: {
   selector: string;
   filePath: string;
-  awaitSuccess?: boolean;
+  selectorToAwaitOnSuccess?: string;
 }) {
   cy.get(selector).attachFile(filePath);
-  if (awaitSuccess) {
-    cy.get('[data-testid^="upload-file-success"]').should('exist');
+  if (selectorToAwaitOnSuccess) {
+    cy.get(selectorToAwaitOnSuccess).should('exist');
   }
 }
diff --git a/cypress/helpers/fileAPetition/create-and-serve-paper-petition-petitioner-and-spouse.ts b/cypress/helpers/fileAPetition/create-and-serve-paper-petition-petitioner-and-spouse.ts
@@ -62,6 +62,7 @@ export function createAndServePaperPetitionMultipleParties(
   attachFile({
     filePath: '../../helpers/file/sample.pdf',
     selector: '#petitionFile-file',
+    selectorToAwaitOnSuccess: '[data-testid="remove-pdf"]',
   });
   cy.get('#tabButton-requestForPlaceOfTrialFile > .button-text').click();
   cy.get('#scan-mode-radios').click();
@@ -70,6 +71,7 @@ export function createAndServePaperPetitionMultipleParties(
   attachFile({
     filePath: '../../helpers/file/sample.pdf',
     selector: '#requestForPlaceOfTrialFile-file',
+    selectorToAwaitOnSuccess: '[data-testid="remove-pdf"]',
   });
   cy.get('[data-testid="submit-paper-petition"]').click();
   return cy

diff --git a/cypress/helpers/fileAPetition/create-and-serve-paper-petition.ts b/cypress/helpers/fileAPetition/create-and-serve-paper-petition.ts
@@ -47,6 +47,7 @@ export function createAndServePaperPetition(
   attachFile({
     filePath: '../../helpers/file/sample.pdf',
     selector: '#petitionFile-file',
+    selectorToAwaitOnSuccess: '[data-testid="remove-pdf"]',
   });
   cy.get('#tabButton-requestForPlaceOfTrialFile > .button-text').click();
   cy.get('#scan-mode-radios').click();
@@ -55,20 +56,23 @@ export function createAndServePaperPetition(
   attachFile({
     filePath: '../../helpers/file/sample.pdf',
     selector: '#requestForPlaceOfTrialFile-file',
+    selectorToAwaitOnSuccess: '[data-testid="remove-pdf"]',
   });
 
   cy.get('[data-testid="tabButton-stinFile"]').click();
   cy.get('[data-testid="upload-pdf-button"]').click();
   attachFile({
     filePath: '../../helpers/file/sample.pdf',
     selector: 'input#stinFile-file',
+    selectorToAwaitOnSuccess: '[data-testid="remove-pdf"]',
   });
 
   cy.get('[data-testid="tabButton-attachmentToPetitionFile"]').click();
   cy.get('[data-testid="upload-pdf-button"]').click();
   attachFile({
     filePath: '../../helpers/file/sample.pdf',
     selector: 'input#attachmentToPetitionFile-file',
+    selectorToAwaitOnSuccess: '[data-testid="remove-pdf"]',
   });
   cy.get('[data-testid="remove-pdf"]');
 
@@ -77,6 +81,7 @@ export function createAndServePaperPetition(
   attachFile({
     filePath: '../../helpers/file/sample.pdf',
     selector: 'input#corporateDisclosureFile-file',
+    selectorToAwaitOnSuccess: '[data-testid="remove-pdf"]',
   });
 
   cy.get(
@@ -86,6 +91,7 @@ export function createAndServePaperPetition(
   attachFile({
     filePath: '../../helpers/file/sample.pdf',
     selector: 'input#applicationForWaiverOfFilingFeeFile-file',
+    selectorToAwaitOnSuccess: '[data-testid="remove-pdf"]',
   });
 
   cy.get('[data-testid="submit-paper-petition"]').click();
@@ -191,20 +197,23 @@ export function createAndServePaperPetitionMyselfAndSpouse() {
   attachFile({
     filePath: '../../helpers/file/sample.pdf',
     selector: '#petitionFile-file',
+    selectorToAwaitOnSuccess: '[data-testid="remove-pdf"]',
   });
 
   cy.get('#tabButton-requestForPlaceOfTrialFile > .button-text').click();
   cy.get('#upload-mode-upload').click();
   attachFile({
     filePath: '../../helpers/file/sample.pdf',
     selector: '#requestForPlaceOfTrialFile-file',
+    selectorToAwaitOnSuccess: '[data-testid="remove-pdf"]',
   });
 
   cy.get('[data-testid="tabButton-stinFile"]').click();
   cy.get('[data-testid="upload-pdf-button"]').click();
   attachFile({
     filePath: '../../helpers/file/sample.pdf',
     selector: 'input#stinFile-file',
+    selectorToAwaitOnSuccess: '[data-testid="remove-pdf"]',
   });
 
   cy.get('[data-testid="submit-paper-petition"]').click();

diff --git a/cypress/helpers/fileAPetition/petitioner-creates-electronic-case-updated.ts b/cypress/helpers/fileAPetition/petitioner-creates-electronic-case-updated.ts
@@ -125,7 +125,6 @@ export function petitionerAttemptsToUploadCorruptPdfUpdated() {
   cy.get('[data-testid="step-4-next-button"]').click();
 
   attachFile({
-    awaitSuccess: false,
     filePath: '../../helpers/file/corrupt-pdf.pdf',
     selector: '[data-testid="stin-file"]',
   });

diff --git a/cypress/helpers/fileAPetition/petitioner-creates-electronic-case.ts b/cypress/helpers/fileAPetition/petitioner-creates-electronic-case.ts
@@ -295,7 +295,6 @@ export function petitionerAttemptsToUploadCorruptPdfOld() {
   cy.get('[data-testid="file-a-petition"]').click();
   cy.get('[data-testid="go-to-step-1"]').click();
   attachFile({
-    awaitSuccess: false,
     filePath: '../../helpers/file/corrupt-pdf.pdf',
     selector: '[data-testid="stin-file"]',
   });

diff --git a/cypress/local-only/support/pages/create-paper-petition.ts b/cypress/local-only/support/pages/create-paper-petition.ts
@@ -92,6 +92,7 @@ export const fillInCreateCaseFromPaperForm = (testData?: {
   attachFile({
     filePath: '../../helpers/file/sample.pdf',
     selector: 'input#petitionFile-file',
+    selectorToAwaitOnSuccess: '[data-testid="remove-pdf"]',
   });
   cy.get('[data-testid="remove-pdf"]');
 
@@ -101,6 +102,7 @@ export const fillInCreateCaseFromPaperForm = (testData?: {
   attachFile({
     filePath: '../../helpers/file/sample.pdf',
     selector: 'input#stinFile-file',
+    selectorToAwaitOnSuccess: '[data-testid="remove-pdf"]',
   });
   cy.get('[data-testid="remove-pdf"]');
 
@@ -110,6 +112,7 @@ export const fillInCreateCaseFromPaperForm = (testData?: {
   attachFile({
     filePath: '../../helpers/file/sample.pdf',
     selector: 'input#requestForPlaceOfTrialFile-file',
+    selectorToAwaitOnSuccess: '[data-testid="remove-pdf"]',
   });
   cy.get('[data-testid="remove-pdf"]');
   cy.get('[data-testid="icon-requestForPlaceOfTrialFile"]').should(
@@ -122,6 +125,7 @@ export const fillInCreateCaseFromPaperForm = (testData?: {
   attachFile({
     filePath: '../../helpers/file/sample.pdf',
     selector: 'input#attachmentToPetitionFile-file',
+    selectorToAwaitOnSuccess: '[data-testid="remove-pdf"]',
   });
 
   cy.get('[data-testid="remove-pdf"]');

diff --git a/cypress/local-only/support/pages/document-qc.ts b/cypress/local-only/support/pages/document-qc.ts
@@ -57,6 +57,7 @@ export const uploadCourtIssuedDocumentAndEditViaDocumentQC = () => {
   attachFile({
     filePath: '../../helpers/file/sample.pdf',
     selector: 'input#primary-document-file',
+    selectorToAwaitOnSuccess: '[data-testid="remove-pdf"]',
   });
   cy.get('[data-testid="upload-file-success"]');
   cy.get('#save-uploaded-pdf-button').click();

diff --git a/cypress/local-only/tests/integration/caseDetail/consolidated-case.cy.ts b/cypress/local-only/tests/integration/caseDetail/consolidated-case.cy.ts
@@ -57,6 +57,7 @@ describe('Docket clerk views consolidated case', function () {
       attachFile({
         filePath: '../../helpers/file/sample.pdf',
         selector: 'input#primaryDocumentFile-file',
+        selectorToAwaitOnSuccess: '[data-testid="remove-pdf"]',
       });
       cy.get('[data-testid="remove-pdf"]');
       cy.get('button#upload-correspondence').click();

diff --git a/.../local-only/tests/integration/caseDetail/docketRecord/courtIssuedFiling/stamp-order.cy.ts b/.../local-only/tests/integration/caseDetail/docketRecord/courtIssuedFiling/stamp-order.cy.ts
@@ -24,6 +24,7 @@ describe('Judge`s chambers stamps an order', () => {
       attachFile({
         filePath: '../../helpers/file/sample.pdf',
         selector: 'input#primaryDocumentFile-file',
+        selectorToAwaitOnSuccess: '[data-testid="remove-pdf"]',
       });
       cy.get('[data-testid="remove-pdf"]');
       cy.get('[data-testid="save-and-serve"]').click();

diff --git a/...ocal-only/tests/integration/caseDetail/docketRecord/electronicFiling/file-an-answer.cy.ts b/...ocal-only/tests/integration/caseDetail/docketRecord/electronicFiling/file-an-answer.cy.ts
@@ -22,6 +22,7 @@ describe('Filing an Answer', function () {
     attachFile({
       filePath: '../../helpers/file/sample.pdf',
       selector: '#primary-document',
+      selectorToAwaitOnSuccess: '[data-testid^="upload-file-success"]',
     });
     cy.get('label#primary-document-label').should('have.class', 'validated');
   });

diff --git a/...gration/caseDetail/docketRecord/electronicFiling/petitioner-files-external-document.cy.ts b/...gration/caseDetail/docketRecord/electronicFiling/petitioner-files-external-document.cy.ts
@@ -26,6 +26,7 @@ describe(
       attachFile({
         filePath: '../../helpers/file/sample.pdf',
         selector: '[data-testid="primary-document"]',
+        selectorToAwaitOnSuccess: '[data-testid^="upload-file-success"]',
       });
       cy.get('[data-testid=primaryDocument-objections-No]').click();
       cy.get('#submit-document').click();

diff --git a/...aseDetail/docketRecord/electronicFiling/petitioner-files-motion-to-stay-proceedings.cy.ts b/...aseDetail/docketRecord/electronicFiling/petitioner-files-motion-to-stay-proceedings.cy.ts
@@ -52,6 +52,7 @@ describe('Private Practitioner requests to represent a party to a case', () => {
       attachFile({
         filePath: '../../helpers/file/sample.pdf',
         selector: 'input#primaryDocumentFile-file',
+        selectorToAwaitOnSuccess: '[data-testid="remove-pdf"]',
       });
 
       cy.get('[data-testid="save-for-later"]').click();
@@ -100,6 +101,7 @@ describe('Petitioner files motion to lift stay of proceedings', () => {
     attachFile({
       filePath: '../../helpers/file/sample.pdf',
       selector: '[data-testid="primary-document"]',
+      selectorToAwaitOnSuccess: '[data-testid^="upload-file-success"]',
     });
     cy.get('[data-testid=primaryDocument-objections-No]').click();
     cy.get('#submit-document').click();

diff --git a/cypress/local-only/tests/integration/documentQC/docket-clerk-qcs-paper-filing.cy.ts b/cypress/local-only/tests/integration/documentQC/docket-clerk-qcs-paper-filing.cy.ts
@@ -59,6 +59,7 @@ describe('Docket clerk QC-ing a paper filing', () => {
       attachFile({
         filePath: '../../helpers/file/sample.pdf',
         selector: 'input#primaryDocumentFile-file',
+        selectorToAwaitOnSuccess: '[data-testid="remove-pdf"]',
       });
 
       cy.get('[data-testid="save-for-later"]').click();

diff --git a/cypress/local-only/tests/integration/fileAPetition/file-a-petition.cy.ts b/cypress/local-only/tests/integration/fileAPetition/file-a-petition.cy.ts
@@ -62,6 +62,7 @@ describe('File a Petition', () => {
       attachFile({
         filePath: '../../helpers/file/sample.pdf',
         selector: 'input#stin-file',
+        selectorToAwaitOnSuccess: '[data-testid="remove-pdf"]',
       });
       cy.get('label#stin-file-label').should('have.class', 'validated');
     });
@@ -82,6 +83,7 @@ describe('File a Petition', () => {
       attachFile({
         filePath: '../../helpers/file/sample.pdf',
         selector: 'input#petition-file',
+        selectorToAwaitOnSuccess: '[data-testid="remove-pdf"]',
       });
 
       cy.get('label#petition-file-label').should('have.class', 'validated');

diff --git a/...ss/local-only/tests/integration/fileAPetitionUpdated/file-a-petition-corupted-files.cy.ts b/...ss/local-only/tests/integration/fileAPetitionUpdated/file-a-petition-corupted-files.cy.ts
@@ -22,7 +22,6 @@ describe('File a petition - Corrupted Files', () => {
 
     cy.get('[data-testid="upload-a-petition-label"').click();
     attachFile({
-      awaitSuccess: false,
       filePath: CORRUPTED_FILE,
       selector: '#petition-file',
     });
@@ -38,7 +37,6 @@ describe('File a petition - Corrupted Files', () => {
 
     cy.get('[data-testid="irs-notice-Yes"]').click();
     attachFile({
-      awaitSuccess: false,
       filePath: CORRUPTED_FILE,
       selector: '[data-testid="irs-notice-upload-0"]',
     });
@@ -57,7 +55,6 @@ describe('File a petition - Corrupted Files', () => {
     fillCaseProcedureInformation();
 
     attachFile({
-      awaitSuccess: false,
       filePath: CORRUPTED_FILE,
       selector: '[data-testid="stin-file"]',
     });

diff --git a/...tests/integration/fileAPetitionUpdated/file-a-petition-step-1-business--corporation.cy.ts b/...tests/integration/fileAPetitionUpdated/file-a-petition-step-1-business--corporation.cy.ts
@@ -126,6 +126,7 @@ describe('File a petition: Step 1 - Petitioner Information', () => {
               attachFile({
                 filePath: uploadFile,
                 selector: `[data-testid="${input}"]`,
+                selectorToAwaitOnSuccess: '[data-testid="remove-pdf"]',
               });
             }
           });
@@ -190,6 +191,7 @@ describe('File a petition: Step 1 - Petitioner Information', () => {
               attachFile({
                 filePath: uploadFile,
                 selector: `[data-testid="${input}"]`,
+                selectorToAwaitOnSuccess: '[data-testid="remove-pdf"]',
               });
             }
           });
@@ -285,6 +287,7 @@ describe('File a petition: Step 1 - Petitioner Information', () => {
               attachFile({
                 filePath: uploadFile,
                 selector: `[data-testid="${input}"]`,
+                selectorToAwaitOnSuccess: '[data-testid="remove-pdf"]',
               });
             }
           });
@@ -349,6 +352,7 @@ describe('File a petition: Step 1 - Petitioner Information', () => {
               attachFile({
                 filePath: uploadFile,
                 selector: `[data-testid="${input}"]`,
+                selectorToAwaitOnSuccess: '[data-testid="remove-pdf"]',
               });
             }
           });

diff --git a/...Updated/file-a-petition-step-1-business--partnership-other-than-tax-matters-partner.cy.ts b/...Updated/file-a-petition-step-1-business--partnership-other-than-tax-matters-partner.cy.ts
@@ -135,6 +135,7 @@ describe('File a petition: Step 1 - Petitioner Information', () => {
               attachFile({
                 filePath: uploadFile,
                 selector: `[data-testid="${input}"]`,
+                selectorToAwaitOnSuccess: '[data-testid="remove-pdf"]',
               });
             }
           });
@@ -206,6 +207,7 @@ describe('File a petition: Step 1 - Petitioner Information', () => {
               attachFile({
                 filePath: uploadFile,
                 selector: `[data-testid="${input}"]`,
+                selectorToAwaitOnSuccess: '[data-testid="remove-pdf"]',
               });
             }
           });
@@ -310,6 +312,7 @@ describe('File a petition: Step 1 - Petitioner Information', () => {
               attachFile({
                 filePath: uploadFile,
                 selector: `[data-testid="${input}"]`,
+                selectorToAwaitOnSuccess: '[data-testid="remove-pdf"]',
               });
             }
           });
@@ -381,6 +384,7 @@ describe('File a petition: Step 1 - Petitioner Information', () => {
               attachFile({
                 filePath: uploadFile,
                 selector: `[data-testid="${input}"]`,
+                selectorToAwaitOnSuccess: '[data-testid="remove-pdf"]',
               });
             }
           });

diff --git a/...titionUpdated/file-a-petition-step-1-business--partnership-representative-under-BBA.cy.ts b/...titionUpdated/file-a-petition-step-1-business--partnership-representative-under-BBA.cy.ts
@@ -132,6 +132,7 @@ describe('File a petition: Step 1 - Petitioner Information', () => {
               attachFile({
                 filePath: uploadFile,
                 selector: `[data-testid="${input}"]`,
+                selectorToAwaitOnSuccess: '[data-testid="remove-pdf"]',
               });
             }
           });
@@ -201,6 +202,7 @@ describe('File a petition: Step 1 - Petitioner Information', () => {
               attachFile({
                 filePath: uploadFile,
                 selector: `[data-testid="${input}"]`,
+                selectorToAwaitOnSuccess: '[data-testid="remove-pdf"]',
               });
             }
           });
@@ -302,6 +304,7 @@ describe('File a petition: Step 1 - Petitioner Information', () => {
               attachFile({
                 filePath: uploadFile,
                 selector: `[data-testid="${input}"]`,
+                selectorToAwaitOnSuccess: '[data-testid="remove-pdf"]',
               });
             }
           });
@@ -371,6 +374,7 @@ describe('File a petition: Step 1 - Petitioner Information', () => {
               attachFile({
                 filePath: uploadFile,
                 selector: `[data-testid="${input}"]`,
+                selectorToAwaitOnSuccess: '[data-testid="remove-pdf"]',
               });
             }
           });

diff --git a/...leAPetitionUpdated/file-a-petition-step-1-business--partnership-tax-matters-partner.cy.ts b/...leAPetitionUpdated/file-a-petition-step-1-business--partnership-tax-matters-partner.cy.ts
@@ -132,6 +132,7 @@ describe('File a petition: Step 1 - Petitioner Information', () => {
               attachFile({
                 filePath: uploadFile,
                 selector: `[data-testid="${input}"]`,
+                selectorToAwaitOnSuccess: '[data-testid="remove-pdf"]',
               });
             }
           });
@@ -201,6 +202,7 @@ describe('File a petition: Step 1 - Petitioner Information', () => {
               attachFile({
                 filePath: uploadFile,
                 selector: `[data-testid="${input}"]`,
+                selectorToAwaitOnSuccess: '[data-testid="remove-pdf"]',
               });
             }
           });
@@ -302,6 +304,7 @@ describe('File a petition: Step 1 - Petitioner Information', () => {
               attachFile({
                 filePath: uploadFile,
                 selector: `[data-testid="${input}"]`,
+                selectorToAwaitOnSuccess: '[data-testid="remove-pdf"]',
               });
             }
           });
@@ -372,6 +375,7 @@ describe('File a petition: Step 1 - Petitioner Information', () => {
               attachFile({
                 filePath: uploadFile,
                 selector: `[data-testid="${input}"]`,
+                selectorToAwaitOnSuccess: '[data-testid="remove-pdf"]',
               });
             }
           });