10409: more test fixes

ustaxcourt · Sep 23, 2024 · c38fe65 · c38fe65
1 parent 5dc7ace
commit c38fe65
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 8 deletions.
diff --git a/web-client/src/presenter/computeds/trialSessionsHelper.test.ts b/web-client/src/presenter/computeds/trialSessionsHelper.test.ts
@@ -262,14 +262,19 @@ describe('trialSessionsHelper', () => {
   describe('trialSessionRows', () => {
     describe('filters', () => {
       it('should filter trial sessions by judge', () => {
-        trialSession1.judge!.userId = '1';
-        trialSession2.judge!.userId = '2';
+        trialSession1.judge!.userId = '43b00e5f-b78c-476c-820e-5d6ed1d58828';
+        trialSession2.judge!.userId = 'd17b07dc-6455-447e-bea3-f91d12ac5a6';
         trialSessionsPageState.trialSessions = [trialSession1, trialSession2];
-        trialSessionsPageState.filters.judgeId = '1';
+        trialSessionsPageState.filters.judges = {
+          'd17b07dc-6455-447e-bea3-f91d12ac5a6': {
+            name: 'Colvin',
+            userId: 'd17b07dc-6455-447e-bea3-f91d12ac5a6',
+          },
+        };
 
         const result = runCompute(trialSessionsHelper, {
           state: {
-            judges: [judgeUser],
+            judges: [judgeUser, judgeColvin],
             permissions: getUserPermissions(docketClerk1User),
             trialSessionsPage: trialSessionsPageState,
           },
@@ -302,9 +307,6 @@ describe('trialSessionsHelper', () => {
         );
       });
 
-      // #ix this
-      // TODO: This test is affectd by pagination now. Ergo, one trial sessionis filtered out
-      //      when it should not be base on this test
       it('should not filter trial sessions by judge when judge filter is All', () => {
         trialSessionsPageState.trialSessions = [trialSession1, trialSession2];
         trialSessionsPageState.filters.judgeId = 'All';

diff --git a/web-client/src/presenter/computeds/trialSessionsHelper.ts b/web-client/src/presenter/computeds/trialSessionsHelper.ts
@@ -51,7 +51,7 @@ export const trialSessionsHelper = (
   const judge = get(state.judgeUser);
   const judges = get(state.judges);
 
-  const pageSize = 1;
+  const pageSize = 5; // set this to sane value for testing purposes
 
   const showCurrentJudgesOnly =
     filters.currentTab === 'new' ||
@@ -79,6 +79,7 @@ export const trialSessionsHelper = (
     label: sessionType,
     value: sessionType,
   }));
+
   const trialSessionJudgeOptions = trialSessionJudges.map(
     trialSessionJudge => ({
       label: trialSessionJudge.name,
@@ -97,10 +98,12 @@ export const trialSessionsHelper = (
     filters,
     trialSessions,
   });
+
   const trialSessionPage = filteredTrialSessions.slice(
     filters.pageNumber * pageSize,
     filters.pageNumber * pageSize + pageSize,
   );
+
   const trialSessionRows = formatTrialSessions({
     judgeAssociatedToUser: judge,
     trialSessions: trialSessionPage,