dep-updates: Make pdf-generator lambda return an object so that direc…

…t invocations can rely on a specific shape.

web-api/src/business/useCases/pdf/generatePdfFromHtmlInteractor.test.ts

@@ -7,7 +7,7 @@ const lambdaClientMock = jest
   .spyOn(LambdaClient.prototype, 'send')
   .mockImplementation(() => {
     return {
-      Payload: Buffer.from(JSON.stringify({ key: documentKey })),
+      Payload: Buffer.from(JSON.stringify({ tempId: documentKey })),
     };
   });
 
@@ -46,4 +46,32 @@ describe('generatePdfFromHtmlInteractor', () => {
       applicationContext.getPersistenceGateway().getDocument,
     ).toHaveBeenCalled();
   });
+
+  it('should throw an error when the pdf generator lambda does not generate a file id', async () => {
+    applicationContext.environment.stage = 'prod';
+    applicationContext.environment.currentColor = 'blue';
+    jest.spyOn(LambdaClient.prototype, 'send').mockImplementation(() => {
+      return {
+        Payload: Buffer.from(JSON.stringify({})),
+      };
+    });
+
+    await expect(
+      generatePdfFromHtmlInteractor(applicationContext, {
+        contentHtml: '<p>this is content</p>',
+        displayHeaderFooter: false,
+        docketNumber: '102-24',
+        footerHtml: '<div>this is a footer</div>',
+        headerHtml: '<span>this is a header</span>',
+        overwriteFooter: false,
+      }),
+    ).rejects.toThrow(
+      `Unable to generate pdf. Check pdf_generator_${applicationContext.environment.stage}_${applicationContext.environment.currentColor} lambda for errors`,
+    );
+
+    expect(lambdaClientMock).toHaveBeenCalled();
+    expect(
+      applicationContext.getPersistenceGateway().getDocument,
+    ).not.toHaveBeenCalled();
+  });
 });

web-api/src/business/useCases/pdf/generatePdfFromHtmlInteractor.ts

@@ -1,4 +1,5 @@
 import { InvokeCommand, LambdaClient } from '@aws-sdk/client-lambda';
+import { PdfGenerationResult } from '@web-api/lambdas/pdfGeneration/pdf-generation';
 import { ServerApplicationContext } from '@web-api/applicationContext';
 
 export const generatePdfFromHtmlInteractor = async (
@@ -63,8 +64,21 @@ export const generatePdfFromHtmlInteractor = async (
 
   const response = await client.send(command);
   const textDecoder = new TextDecoder('utf-8');
-  const responseStr = textDecoder.decode(response.Payload);
-  const key = JSON.parse(responseStr);
+  let key: string;
+  try {
+    const responseStr = textDecoder.decode(response.Payload);
+    const pdfGenerationResult: PdfGenerationResult = JSON.parse(responseStr);
+    if (!pdfGenerationResult.tempId) {
+      throw new Error(
+        `Unable to generate pdf. Check pdf_generator_${stage}_${currentColor} lambda for errors`,
+      );
+    }
+    key = pdfGenerationResult.tempId;
+  } catch (e) {
+    throw new Error(
+      `Unable to generate pdf. Check pdf_generator_${stage}_${currentColor} lambda for errors`,
+    );
+  }
 
   return await applicationContext.getPersistenceGateway().getDocument({
     applicationContext,

web-api/src/lambdas/pdfGeneration/pdf-generation.ts

@@ -1,5 +1,9 @@
 import { createApplicationContext } from '../../applicationContext';
 
+export type PdfGenerationResult = {
+  tempId: string;
+};
+
 export const handler = async event => {
   const applicationContext = createApplicationContext({});
 
@@ -20,7 +24,7 @@ export const handler = async event => {
     useTempBucket: true,
   });
 
-  return tempId;
+  return { tempId };
 };
 
 export const changeOfAddressHandler = async event => {