Merge pull request #5230 from flexion/10433-design-debt-petitioner-ba…

…nner 10433 Design Debt: Inaccurate Banner for Petitioner
ustaxcourt · Aug 14, 2024 · 98ddfa1 · 98ddfa1
2 parents 9123806 + 2f5022e
commit 98ddfa1
Show file tree

Hide file tree

Showing 2 changed files with 42 additions and 18 deletions.
diff --git a/web-client/src/presenter/computeds/caseDetailHelper.test.ts b/web-client/src/presenter/computeds/caseDetailHelper.test.ts
@@ -449,7 +449,23 @@ describe('case detail computed', () => {
     expect(result.showPetitionProcessingAlert).toEqual(false);
   });
 
-  it('should show petition processing alert if user is an external user and the case does not allow service', () => {
+  it('should not show petition processing alert if user is not associated with the case', () => {
+    const user = petitionerUser;
+
+    const result = runCompute(caseDetailHelper, {
+      state: {
+        ...getBaseState(user),
+        caseDetail: {
+          docketEntries: [{ documentType: 'Petition' }],
+          screenMetadata: { isAssociated: false },
+          status: CASE_STATUS_TYPES.generalDocket,
+        },
+      },
+    });
+    expect(result.showPetitionProcessingAlert).toEqual(false);
+  });
+
+  it('should show petition processing alert if user is an external user and the case does not allow service and user is associated with the case', () => {
     const user = petitionerUser;
 
     const result = runCompute(caseDetailHelper, {
@@ -459,6 +475,7 @@ describe('case detail computed', () => {
           docketEntries: [{ documentType: 'Petition' }],
           status: CASE_STATUS_TYPES.new,
         },
+        screenMetadata: { isAssociated: true },
       },
     });
     expect(result.showPetitionProcessingAlert).toEqual(true);

diff --git a/web-client/src/presenter/computeds/caseDetailHelper.ts b/web-client/src/presenter/computeds/caseDetailHelper.ts
@@ -21,8 +21,7 @@ export const caseDetailHelper = (
   const isExternalUser = applicationContext
     .getUtilities()
     .isExternalUser(user.role);
-  const userAssociatedWithCase = get(state.screenMetadata.isAssociated);
-  const showJudgesNotes = permissions.JUDGES_NOTES;
+  const userIsAssociatedWithCase = get(state.screenMetadata.isAssociated);
 
   let showFileDocumentButton =
     permissions.FILE_EXTERNAL_DOCUMENT && ['CaseDetail'].includes(currentPage);
@@ -34,7 +33,7 @@ export const caseDetailHelper = (
   let showQcWorkItemsUntouchedState = false;
 
   if (isExternalUser) {
-    if (userAssociatedWithCase) {
+    if (userIsAssociatedWithCase) {
       userHasAccessToCase = true;
       showFileDocumentButton = true;
 
@@ -71,22 +70,34 @@ export const caseDetailHelper = (
     .getUtilities()
     .isSealedCase(caseDetail);
 
-  const userCanViewCase =
-    (isExternalUser && userAssociatedWithCase) || !isSealedCase;
+  const showConsolidatedCasesCard =
+    permissions.VIEW_CONSOLIDATED_CASES_CARD && !!caseDetail.leadDocketNumber;
+
+  const showFilingFeeExternal =
+    isExternalUser &&
+    user.role !== USER_ROLES.irsPractitioner &&
+    user.role !== USER_ROLES.irsSuperuser;
+
+  const showJudgesNotes = permissions.JUDGES_NOTES;
+
+  const showPetitionProcessingAlert =
+    isExternalUser &&
+    !canAllowDocumentServiceForCase &&
+    userIsAssociatedWithCase;
+
+  const showPractitionerSection = !isExternalUser || hasPrivatePractitioners;
 
   const isPractitioner =
     user.role === USER_ROLES.irsPractitioner ||
     user.role === USER_ROLES.privatePractitioner;
-
   const isPetitioner = user.role === USER_ROLES.petitioner;
-
   const showSealedCaseView =
     (isPractitioner || isPetitioner) &&
     !!isSealedCase &&
-    !userAssociatedWithCase;
+    !userIsAssociatedWithCase;
 
-  const showConsolidatedCasesCard =
-    permissions.VIEW_CONSOLIDATED_CASES_CARD && !!caseDetail.leadDocketNumber;
+  const userCanViewCase =
+    (isExternalUser && userIsAssociatedWithCase) || !isSealedCase;
 
   return {
     caseDeadlines,
@@ -105,14 +116,10 @@ export const caseDetailHelper = (
     showDocketRecordInProgressState: !isExternalUser,
     showEditCaseDetailsButton: permissions.EDIT_CASE_DETAILS,
     showFileDocumentButton,
-    showFilingFeeExternal:
-      isExternalUser &&
-      user.role !== USER_ROLES.irsPractitioner &&
-      user.role !== USER_ROLES.irsSuperuser,
+    showFilingFeeExternal,
     showJudgesNotes,
-    showPetitionProcessingAlert:
-      isExternalUser && !canAllowDocumentServiceForCase,
-    showPractitionerSection: !isExternalUser || hasPrivatePractitioners,
+    showPetitionProcessingAlert,
+    showPractitionerSection,
     showPreferredTrialCity: caseDetail.preferredTrialCity,
     showQcWorkItemsUntouchedState,
     showSealedCaseView,