10074-bug: update a few more overlooked forms

ustaxcourt · Sep 24, 2024 · 8fb1b8d · 8fb1b8d
1 parent dd6d219
commit 8fb1b8d
Show file tree

Hide file tree

Showing 9 changed files with 37 additions and 22 deletions.
diff --git a/web-client/src/presenter/actions/validateCaseDetailsAction.ts b/web-client/src/presenter/actions/validateCaseDetailsAction.ts
@@ -18,6 +18,7 @@ export const validateCaseDetailsAction = async ({
         caseDetail: {
           ...caseDetail,
           ...form,
+          caseType: form.caseType || null,
           petitionPaymentDate: form.petitionPaymentDate || null,
           petitionPaymentMethod: form.petitionPaymentMethod || null,
           preferredTrialCity: form.preferredTrialCity

diff --git a/web-client/src/presenter/sequences/Login/submitChangePasswordSequence.ts b/web-client/src/presenter/sequences/Login/submitChangePasswordSequence.ts
@@ -5,11 +5,9 @@ import { navigateToLoginAction } from '@web-client/presenter/actions/Login/navig
 import { navigateToPathAction } from '@web-client/presenter/actions/navigateToPathAction';
 import { setAlertErrorAction } from '@web-client/presenter/actions/setAlertErrorAction';
 import { setSaveAlertsForNavigationAction } from '@web-client/presenter/actions/setSaveAlertsForNavigationAction';
-import { setScrollToErrorNotificationAction } from '@web-client/presenter/actions/setScrollToErrorNotificationAction';
 import { setTokenAction } from '@web-client/presenter/actions/Login/setTokenAction';
 import { setUserAction } from '@web-client/presenter/actions/setUserAction';
 import { setUserPermissionsAction } from '@web-client/presenter/actions/setUserPermissionsAction';
-import { setValidationAlertErrorsAction } from '@web-client/presenter/actions/setValidationAlertErrorsAction';
 import { setValidationErrorsAction } from '@web-client/presenter/actions/setValidationErrorsAction';
 import { showProgressSequenceDecorator } from '../../utilities/showProgressSequenceDecorator';
 import { submitChangePasswordAction } from '@web-client/presenter/actions/Login/submitChangePasswordAction';
@@ -20,11 +18,7 @@ export const submitChangePasswordSequence = [
     clearAlertsAction,
     validateChangePasswordFormAction,
     {
-      error: [
-        setValidationErrorsAction,
-        setScrollToErrorNotificationAction,
-        setValidationAlertErrorsAction,
-      ],
+      error: [setValidationErrorsAction],
       success: [
         submitChangePasswordAction,
         {

diff --git a/web-client/src/presenter/sequences/Public/submitPublicCaseAdvancedSearchSequence.ts b/web-client/src/presenter/sequences/Public/submitPublicCaseAdvancedSearchSequence.ts
@@ -3,7 +3,8 @@ import { clearSearchResultsAction } from '../../actions/AdvancedSearch/clearSear
 import { clearSearchTermAction } from '../../actions/clearSearchTermAction';
 import { defaultCaseSearchDatesAction } from '@web-client/presenter/actions/AdvancedSearch/defaultCaseSearchDatesAction';
 import { setAdvancedSearchResultsAction } from '../../actions/AdvancedSearch/setAdvancedSearchResultsAction';
-import { setAlertErrorAction } from '../../actions/setAlertErrorAction';
+import { setScrollToErrorNotificationAction } from '@web-client/presenter/actions/setScrollToErrorNotificationAction';
+import { setValidationAlertErrorsAction } from '@web-client/presenter/actions/setValidationAlertErrorsAction';
 import { setValidationErrorsAction } from '../../actions/setValidationErrorsAction';
 import { showProgressSequenceDecorator } from '../../utilities/showProgressSequenceDecorator';
 import { startShowValidationAction } from '@web-client/presenter/actions/startShowValidationAction';
@@ -16,10 +17,11 @@ export const submitPublicCaseAdvancedSearchSequence = [
   validateCaseAdvancedSearchAction,
   {
     error: [
-      setAlertErrorAction,
+      startShowValidationAction,
       setValidationErrorsAction,
+      setScrollToErrorNotificationAction,
+      setValidationAlertErrorsAction,
       clearSearchResultsAction,
-      startShowValidationAction,
     ],
     success: showProgressSequenceDecorator([
       clearAlertsAction,

diff --git a/web-client/src/presenter/sequences/Public/submitPublicCaseDocketNumberSearchSequence.ts b/web-client/src/presenter/sequences/Public/submitPublicCaseDocketNumberSearchSequence.ts
@@ -2,9 +2,10 @@ import { caseExistsAction } from '../../actions/caseExistsAction';
 import { clearSearchResultsAction } from '../../actions/AdvancedSearch/clearSearchResultsAction';
 import { clearSearchTermAction } from '../../actions/clearSearchTermAction';
 import { navigateToCaseDetailAction } from '../../actions/navigateToCaseDetailAction';
-import { setAlertErrorAction } from '../../actions/setAlertErrorAction';
 import { setDocketNumberFromAdvancedSearchAction } from '../../actions/AdvancedSearch/setDocketNumberFromAdvancedSearchAction';
 import { setNoMatchesCaseSearchAction } from '../../actions/AdvancedSearch/setNoMatchesCaseSearchAction';
+import { setScrollToErrorNotificationAction } from '@web-client/presenter/actions/setScrollToErrorNotificationAction';
+import { setValidationAlertErrorsAction } from '@web-client/presenter/actions/setValidationAlertErrorsAction';
 import { setValidationErrorsAction } from '../../actions/setValidationErrorsAction';
 import { showProgressSequenceDecorator } from '../../utilities/showProgressSequenceDecorator';
 import { startShowValidationAction } from '../../actions/startShowValidationAction';
@@ -17,8 +18,9 @@ export const submitPublicCaseDocketNumberSearchSequence = [
   validateCaseDocketNumberSearchAction,
   {
     error: [
-      setAlertErrorAction,
       setValidationErrorsAction,
+      setScrollToErrorNotificationAction,
+      setValidationAlertErrorsAction,
       clearSearchResultsAction,
     ],
     success: showProgressSequenceDecorator([

diff --git a/web-client/src/presenter/sequences/Public/submitPublicOpinionAdvancedSearchSequence.ts b/web-client/src/presenter/sequences/Public/submitPublicOpinionAdvancedSearchSequence.ts
@@ -2,7 +2,8 @@ import { clearAlertsAction } from '../../actions/clearAlertsAction';
 import { clearSearchResultsAction } from '../../actions/AdvancedSearch/clearSearchResultsAction';
 import { clearSearchTermAction } from '../../actions/clearSearchTermAction';
 import { setAdvancedSearchResultsAction } from '../../actions/AdvancedSearch/setAdvancedSearchResultsAction';
-import { setAlertErrorAction } from '../../actions/setAlertErrorAction';
+import { setScrollToErrorNotificationAction } from '@web-client/presenter/actions/setScrollToErrorNotificationAction';
+import { setValidationAlertErrorsAction } from '@web-client/presenter/actions/setValidationAlertErrorsAction';
 import { setValidationErrorsAction } from '../../actions/setValidationErrorsAction';
 import { showProgressSequenceDecorator } from '../../utilities/showProgressSequenceDecorator';
 import { startShowValidationAction } from '../../actions/startShowValidationAction';
@@ -14,10 +15,11 @@ export const submitPublicOpinionAdvancedSearchSequence = [
   validateOpinionAdvancedSearchAction,
   {
     error: [
-      setAlertErrorAction,
+      startShowValidationAction,
       setValidationErrorsAction,
+      setScrollToErrorNotificationAction,
+      setValidationAlertErrorsAction,
       clearSearchResultsAction,
-      startShowValidationAction,
     ],
     success: showProgressSequenceDecorator([
       clearAlertsAction,

diff --git a/web-client/src/presenter/sequences/Public/submitPublicOrderAdvancedSearchSequence.ts b/web-client/src/presenter/sequences/Public/submitPublicOrderAdvancedSearchSequence.ts
@@ -2,7 +2,8 @@ import { clearAlertsAction } from '../../actions/clearAlertsAction';
 import { clearSearchResultsAction } from '../../actions/AdvancedSearch/clearSearchResultsAction';
 import { clearSearchTermAction } from '../../actions/clearSearchTermAction';
 import { setAdvancedSearchResultsAction } from '../../actions/AdvancedSearch/setAdvancedSearchResultsAction';
-import { setAlertErrorAction } from '../../actions/setAlertErrorAction';
+import { setScrollToErrorNotificationAction } from '@web-client/presenter/actions/setScrollToErrorNotificationAction';
+import { setValidationAlertErrorsAction } from '@web-client/presenter/actions/setValidationAlertErrorsAction';
 import { setValidationErrorsAction } from '../../actions/setValidationErrorsAction';
 import { showProgressSequenceDecorator } from '../../utilities/showProgressSequenceDecorator';
 import { startShowValidationAction } from '../../actions/startShowValidationAction';
@@ -14,10 +15,11 @@ export const submitPublicOrderAdvancedSearchSequence = [
   validateOrderAdvancedSearchAction,
   {
     error: [
-      setAlertErrorAction,
+      startShowValidationAction,
       setValidationErrorsAction,
+      setScrollToErrorNotificationAction,
+      setValidationAlertErrorsAction,
       clearSearchResultsAction,
-      startShowValidationAction,
     ],
     success: showProgressSequenceDecorator([
       clearAlertsAction,

diff --git a/web-client/src/presenter/sequences/submitCaseDocketNumberSearchSequence.ts b/web-client/src/presenter/sequences/submitCaseDocketNumberSearchSequence.ts
@@ -2,9 +2,10 @@ import { caseExistsAction } from '../actions/caseExistsAction';
 import { clearSearchResultsAction } from '../actions/AdvancedSearch/clearSearchResultsAction';
 import { clearSearchTermAction } from '../actions/clearSearchTermAction';
 import { navigateToCaseDetailAction } from '../actions/navigateToCaseDetailAction';
-import { setAlertErrorAction } from '../actions/setAlertErrorAction';
 import { setDocketNumberFromAdvancedSearchAction } from '../actions/AdvancedSearch/setDocketNumberFromAdvancedSearchAction';
 import { setNoMatchesCaseSearchAction } from '../actions/AdvancedSearch/setNoMatchesCaseSearchAction';
+import { setScrollToErrorNotificationAction } from '@web-client/presenter/actions/setScrollToErrorNotificationAction';
+import { setValidationAlertErrorsAction } from '@web-client/presenter/actions/setValidationAlertErrorsAction';
 import { setValidationErrorsAction } from '../actions/setValidationErrorsAction';
 import { showProgressSequenceDecorator } from '../utilities/showProgressSequenceDecorator';
 import { startShowValidationAction } from '../actions/startShowValidationAction';
@@ -17,8 +18,9 @@ export const submitCaseDocketNumberSearchSequence = [
   validateCaseDocketNumberSearchAction,
   {
     error: [
-      setAlertErrorAction,
       setValidationErrorsAction,
+      setScrollToErrorNotificationAction,
+      setValidationAlertErrorsAction,
       clearSearchResultsAction,
     ],
     success: showProgressSequenceDecorator([

diff --git a/web-client/src/presenter/sequences/submitUpdatePractitionerUserSequence.ts b/web-client/src/presenter/sequences/submitUpdatePractitionerUserSequence.ts
@@ -26,7 +26,11 @@ export const submitUpdatePractitionerUserSequence = [
   startShowValidationAction,
   validatePractitionerAction,
   {
-    error: [setValidationErrorsAction, setValidationAlertErrorsAction],
+    error: [
+      setValidationErrorsAction,
+      setScrollToErrorNotificationAction,
+      setValidationAlertErrorsAction,
+    ],
     success: [
       setWaitingForResponseAction,
       hasUpdatedEmailFactoryAction('updatedEmail'),

diff --git a/web-client/src/presenter/sequences/updateCaseDetailsSequence.ts b/web-client/src/presenter/sequences/updateCaseDetailsSequence.ts
@@ -6,6 +6,8 @@ import { setCaseAction } from '../actions/setCaseAction';
 import { setCaseDetailShowEditPetitionFalseAction } from '../actions/setCaseDetailShowEditPetitionFalseAction';
 import { setCaseTypeAction } from '../actions/setCaseTypeAction';
 import { setSaveAlertsForNavigationAction } from '../actions/setSaveAlertsForNavigationAction';
+import { setScrollToErrorNotificationAction } from '@web-client/presenter/actions/setScrollToErrorNotificationAction';
+import { setValidationAlertErrorsAction } from '@web-client/presenter/actions/setValidationAlertErrorsAction';
 import { setValidationErrorsAction } from '../actions/setValidationErrorsAction';
 import { setupCurrentPageAction } from '../actions/setupCurrentPageAction';
 import { startShowValidationAction } from '../actions/startShowValidationAction';
@@ -17,7 +19,11 @@ export const updateCaseDetailsSequence = [
   startShowValidationAction,
   validateCaseDetailsAction,
   {
-    error: [setAlertErrorAction, setValidationErrorsAction],
+    error: [
+      setValidationErrorsAction,
+      setScrollToErrorNotificationAction,
+      setValidationAlertErrorsAction,
+    ],
     success: [
       setupCurrentPageAction('Interstitial'),
       setCaseTypeAction,