Merge branch '10349-bug' of github.com:flexion/ef-cms into 10349-bug

.circleci/config.yml

@@ -2,7 +2,7 @@ version: 2.1
 orbs:
   git-shallow-clone: guitarrapc/[email protected]
 
-efcms-docker-image: &efcms-docker-image $AWS_ACCOUNT_ID.dkr.ecr.us-east-1.amazonaws.com/ef-cms-us-east-1:4.3.5
+efcms-docker-image: &efcms-docker-image $AWS_ACCOUNT_ID.dkr.ecr.us-east-1.amazonaws.com/ef-cms-us-east-1:4.3.6
 
 parameters:
   run_build_and_deploy:
@@ -371,7 +371,7 @@ jobs:
       - run:
           name: Kill Build if Smoketests Failed
           command: |
-            if [ "${READONLY_SMOKETESTS_RESULT}" -ne 0 ]; then 
+            if [ "${READONLY_SMOKETESTS_RESULT}" -ne 0 ]; then
               exit 1
             fi
       - run:

.eslintrc.js

@@ -58,7 +58,10 @@ module.exports = {
     {
       files: ['**/*.ts', '**/*.tsx'],
       rules: {
-        '@typescript-eslint/no-unused-vars': 'error',
+        '@typescript-eslint/no-unused-vars': [
+          'error',
+          { caughtErrors: 'none' },
+        ],
         'no-undef': 'off',
         'no-underscore-dangle': 'off',
         'no-unused-vars': 'off',

.github/workflows/typescript-untouched-files-check.yml → .github/workflows/typescript-all-files-check.yml

@@ -1,10 +1,10 @@
-name: Typescript Untouched File Check
+name: Typescript File Check
 
 on:
   pull_request:
 
 jobs:
-  CheckUntouchedFiles:
+  CheckAllFilesForTypeErrorCount:
     runs-on: ubuntu-latest
 
     steps:
@@ -39,5 +39,5 @@ jobs:
         working-directory: ./targetBranch
         run: npm ci
 
-      - name: Check untouched files
-        run: npx ts-node scripts/checkUntouchedFiles.ts
+      - name: Check files for increased error count
+        run: npx ts-node scripts/checkAllFilesForTypeErrorCount.ts

Dockerfile

@@ -37,12 +37,12 @@ RUN apt-get install -y build-essential
 RUN apt-get install -y libcairo2-dev libpango1.0-dev libjpeg-dev libgif-dev librsvg2-dev
 
 ENV JAVA_HOME=/usr/lib/jvm/java-11-openjdk-amd64
-RUN curl "https://awscli.amazonaws.com/awscli-exe-linux-x86_64-2.17.22.zip" -o "awscliv2.zip" && \
+RUN curl "https://awscli.amazonaws.com/awscli-exe-linux-x86_64-2.17.24.zip" -o "awscliv2.zip" && \
   unzip awscliv2.zip && \
   ./aws/install && \
   rm -rf awscliv2.zip
 
-RUN wget -q -O terraform.zip https://releases.hashicorp.com/terraform/1.9.3/terraform_1.9.3_linux_amd64.zip && \ 
+RUN wget -q -O terraform.zip https://releases.hashicorp.com/terraform/1.9.4/terraform_1.9.4_linux_amd64.zip && \
   unzip -o terraform.zip terraform && \
   rm terraform.zip && \
   cp terraform /usr/local/bin/

cypress/helpers/advancedSearch/external-user-searches-docket-number.ts

@@ -1,4 +1,5 @@
 export function externalUserSearchesDocketNumber(docketNumber: string) {
+  cy.get('[data-testid="docket-search-field"]').should('exist');
   cy.get('[data-testid="docket-search-field"]').type(docketNumber);
   cy.get('[data-testid="search-by-docket-number"]').click();
 }

cypress/helpers/authentication/login-as-helpers.ts

@@ -59,7 +59,7 @@ export function loginAsIrsPractitioner1() {
 }
 
 export function loginAsPetitioner(
-  petitionerUser: 'petitioner' | 'petitioner1' = 'petitioner1',
+  petitionerUser: 'petitioner' | 'petitioner1' | 'petitioner7' = 'petitioner1',
 ) {
   cy.login(petitionerUser);
   cy.get('[data-testid="file-a-petition"]').should('exist');

cypress/helpers/fileAPetition/petitioner-creates-electronic-case-updated.ts

@@ -12,7 +12,7 @@ export function petitionerCreatesElectronicCaseUpdated(
   cy.get('[data-testid="contactPrimary.city"]').type('Orlando');
   cy.get('[data-testid="contactPrimary.state"]').select('AL');
   cy.get('[data-testid="contactPrimary.postalCode"]').type('12345');
-  cy.get('[data-testid="contactPrimary.placeOfLegalResidence"]').select('AL');
+  cy.get('[data-testid="contactPrimary-placeOfLegalResidence"]').select('AL');
   cy.get('[data-testid="contact-primary-phone"]').type('1111111111');
   cy.get('[data-testid="step-1-next-button"]').click();
 
@@ -105,7 +105,7 @@ export function petitionerAttemptsToUploadCorruptPdfUpdated() {
   cy.get('[data-testid="contactPrimary.city"]').type('Orlando');
   cy.get('[data-testid="contactPrimary.state"]').select('AL');
   cy.get('[data-testid="contactPrimary.postalCode"]').type('12345');
-  cy.get('[data-testid="contactPrimary.placeOfLegalResidence"]').select('AL');
+  cy.get('[data-testid="contactPrimary-placeOfLegalResidence"]').select('AL');
   cy.get('[data-testid="contact-primary-phone"]').type('1111111111');
   cy.get('[data-testid="step-1-next-button"]').click();
 

cypress/local-only/support/statusReportOrder.ts

@@ -0,0 +1,46 @@
+import {
+  FORMATS,
+  formatNow,
+} from '../../../shared/src/business/utilities/DateHandler';
+
+export const docketNumber = '107-19';
+export const leadCaseDocketNumber = '102-67';
+export const statusReportDocketEntryId = '178af2d2-fab1-445a-a729-d3da63517a0a';
+export const messages = {
+  statusReport: {
+    messageId: '73d4365b-8b3a-4b01-9ca3-7087f7a6d4b5',
+    name: 'Status Report',
+  },
+  testStatusReportOrderSigned: {
+    messageId: '32484c7f-4606-49fc-89f1-27ba1d5596be',
+    name: 'Test Status Report Order (Signed)',
+  },
+  testStatusReportOrderUnsigned: {
+    messageId: '34483b5b-29de-4ad4-8caa-59f71ad6d906',
+    name: 'Test Status Report Order (Unsigned)',
+  },
+};
+export const expectedPdfLines = [
+  'On June 28, 2024, a status report was filed (Index no. 5). For cause, it is',
+  `ORDERED that the parties shall file a further status report by ${formatNow(FORMATS.MONTH_DAY_YEAR)}. It is further`,
+  'ORDERED that this case is stricken from the trial session. It is further',
+  'ORDERED that jurisdiction is retained by the undersigned. It is further',
+  'ORDERED that Here is my additional order text.',
+];
+export const selectAllOptionsInForm = () => {
+  cy.get('#order-type-status-report').check({ force: true });
+  cy.get('#status-report-due-date-picker').type(formatNow(FORMATS.MMDDYYYY));
+  cy.get('#stricken-from-trial-sessions').check({ force: true });
+  cy.get('#jurisdiction-retained').check({ force: true });
+  cy.get('#additional-order-text').type('Here is my additional order text.');
+};
+
+export const getLastDraftOrderElementFromDrafts = () => {
+  return cy.get('button:contains(Order)').last();
+};
+
+export const getLastDraftOrderElementIndexFromDrafts = () => {
+  return getLastDraftOrderElementFromDrafts().then(lastOrderButton => {
+    return lastOrderButton.index();
+  });
+};

cypress/local-only/tests/accessibility/petitionGeneration/petition-generation-before-filing-a-case.cy.ts

@@ -0,0 +1,15 @@
+import { checkA11y } from '../../../support/generalCommands/checkA11y';
+import { loginAsPetitioner } from '../../../../helpers/authentication/login-as-helpers';
+
+describe('Petition generation - intro pages', () => {
+  it('welcome to dawson: should be free of a11y issues', () => {
+    loginAsPetitioner('petitioner7');
+    checkA11y();
+  });
+
+  it('before filing a case: should be free of a11y issues', () => {
+    loginAsPetitioner();
+    cy.visit('/before-filing-a-petition');
+    checkA11y();
+  });
+});

cypress/local-only/tests/accessibility/petitionGeneration/petition-generation-step-1.cy.ts

@@ -0,0 +1,146 @@
+import { checkA11y } from '../../../support/generalCommands/checkA11y';
+import { loginAsPetitioner } from '../../../../helpers/authentication/login-as-helpers';
+
+describe('Petition generation - step 1', () => {
+  beforeEach(() => {
+    loginAsPetitioner();
+    cy.visit('/file-a-petition/new');
+  });
+
+  describe('Myself', () => {
+    it('Myself - domestic: should be free of a11y issues', () => {
+      cy.get('[data-testid="filing-type-0"').click();
+      checkA11y();
+    });
+
+    it('Myself - international: should be free of a11y issues', () => {
+      cy.get('[data-testid="filing-type-0"').click();
+      cy.get('[data-testid="international-country-btn"]').click();
+      checkA11y();
+    });
+  });
+  describe('Myself and my spouse', () => {
+    it('Myself and my spouse - deceased: should be free of a11y issues', () => {
+      cy.get('[data-testid="filing-type-1"').click();
+      cy.get('[data-testid="is-spouse-deceased-0"]').click();
+      checkA11y();
+    });
+
+    it('Myself and my spouse - not deceased: should be free of a11y issues', () => {
+      cy.get('[data-testid="filing-type-1"').click();
+      cy.get('[data-testid="is-spouse-deceased-1"]').click();
+      cy.get('[data-testid="have-spouse-consent-label"').click();
+      checkA11y();
+    });
+  });
+  describe('Business', () => {
+    it('Corporation: should be free of a11y issues', () => {
+      cy.get('[data-testid="filing-type-2"').click();
+      cy.get('.business-type-radio-option').eq(0).click();
+      checkA11y();
+    });
+
+    it('Partnership (as the Tax Matters Partner): should be free of a11y issues', () => {
+      cy.get('[data-testid="filing-type-2"').click();
+      cy.get('.business-type-radio-option').eq(1).click();
+      checkA11y();
+    });
+
+    it('Partnership (as a partner other than Tax Matters Partner): should be free of a11y issues', () => {
+      cy.get('[data-testid="filing-type-2"').click();
+      cy.get('.business-type-radio-option').eq(2).click();
+      checkA11y();
+    });
+
+    it('Partnership (as a partnership representative under BBA): should be free of a11y issues', () => {
+      cy.get('[data-testid="filing-type-2"').click();
+      cy.get('.business-type-radio-option').eq(3).click();
+      checkA11y();
+    });
+  });
+  describe('Other', () => {
+    describe('An estate or trust', () => {
+      it('Estate with an executor/personal representative/fiduciary/etc.: should be free of a11y issues: should be free of a11y issues', () => {
+        cy.get('[data-testid="filing-type-3"').click();
+        cy.get('[data-testid="other-type-radio-option-0"]').click();
+        cy.get('[data-testid="estate-type-radio-option-0"]').click();
+        checkA11y();
+      });
+
+      it('Estate without an executor/personal representative/fiduciary/etc.: should be free of a11y issues', () => {
+        cy.get('[data-testid="filing-type-3"').click();
+        cy.get('[data-testid="other-type-radio-option-0"]').click();
+        cy.get('[data-testid="estate-type-radio-option-1"]').click();
+        checkA11y();
+      });
+
+      it('Trust: should be free of a11y issues', () => {
+        cy.get('[data-testid="filing-type-3"').click();
+        cy.get('[data-testid="other-type-radio-option-0"]').click();
+        cy.get('[data-testid="estate-type-radio-option-2"]').click();
+        checkA11y();
+      });
+    });
+
+    describe('A minor or legally incompetent person', () => {
+      it('Conservator: should be free of a11y issues', () => {
+        cy.get('[data-testid="filing-type-3"').click();
+        cy.get('[data-testid="other-type-radio-option-1"]').click();
+        cy.get('[data-testid="minor-incompetent-type-radio-option-0"]').click();
+        checkA11y();
+      });
+
+      it('Guardian: should be free of a11y issues', () => {
+        cy.get('[data-testid="filing-type-3"').click();
+        cy.get('[data-testid="other-type-radio-option-1"]').click();
+        cy.get('[data-testid="minor-incompetent-type-radio-option-1"]').click();
+        checkA11y();
+      });
+
+      it('Custodian: should be free of a11y issues', () => {
+        cy.get('[data-testid="filing-type-3"').click();
+        cy.get('[data-testid="other-type-radio-option-1"]').click();
+        cy.get('[data-testid="minor-incompetent-type-radio-option-2"]').click();
+        checkA11y();
+      });
+
+      it('Next friend for a minor (without a guardian, conservator, or other like fiduciary): should be free of a11y issues', () => {
+        cy.get('[data-testid="filing-type-3"').click();
+        cy.get('[data-testid="other-type-radio-option-1"]').click();
+        cy.get('[data-testid="minor-incompetent-type-radio-option-3"]').click();
+        checkA11y();
+      });
+
+      it('Next friend for a legally incompetent person (without a guardian, conservator, or other like fiduciary): should be free of a11y issues', () => {
+        cy.get('[data-testid="filing-type-3"').click();
+        cy.get('[data-testid="other-type-radio-option-1"]').click();
+        cy.get('[data-testid="minor-incompetent-type-radio-option-4"]').click();
+        checkA11y();
+      });
+    });
+
+    describe('Donor', () => {
+      it('Donor: should be free of a11y issues', () => {
+        cy.get('[data-testid="filing-type-3"').click();
+        cy.get('[data-testid="other-type-radio-option-2"]').click();
+        checkA11y();
+      });
+    });
+
+    describe('Transferee', () => {
+      it('Transferee: should be free of a11y issues', () => {
+        cy.get('[data-testid="filing-type-3"').click();
+        cy.get('[data-testid="other-type-radio-option-3"]').click();
+        checkA11y();
+      });
+    });
+
+    describe('Deceased Spouse', () => {
+      it('Deceased Spouse: should be free of a11y issues', () => {
+        cy.get('[data-testid="filing-type-3"').click();
+        cy.get('[data-testid="other-type-radio-option-4"]').click();
+        checkA11y();
+      });
+    });
+  });
+});

cypress/local-only/tests/accessibility/petitionGeneration/petition-generation-step-2.cy.ts

@@ -0,0 +1,22 @@
+import { checkA11y } from '../../../support/generalCommands/checkA11y';
+import { fillPetitionerInformation } from '../../integration/fileAPetitionUpdated/petition-helper';
+import { loginAsPetitioner } from '../../../../helpers/authentication/login-as-helpers';
+
+describe('Petition generation - step 2', () => {
+  beforeEach(() => {
+    loginAsPetitioner();
+    cy.visit('/file-a-petition/new');
+    fillPetitionerInformation();
+  });
+
+  it('Auto generate Petition: should be free of a11y issues', () => {
+    cy.get('[data-testid="add-another-reason-link-button"').click();
+    cy.get('[data-testid="add-another-fact-link-button"').click();
+    checkA11y();
+  });
+
+  it('Upload PDF Petition: should be free of a11y issues', () => {
+    cy.get('[data-testid="upload-a-petition-label"').click();
+    checkA11y();
+  });
+});

cypress/local-only/tests/accessibility/petitionGeneration/petition-generation-step-3.cy.ts

@@ -0,0 +1,27 @@
+import { checkA11y } from '../../../support/generalCommands/checkA11y';
+import {
+  fillPetitionFileInformation,
+  fillPetitionerInformation,
+} from '../../integration/fileAPetitionUpdated/petition-helper';
+import { loginAsPetitioner } from '../../../../helpers/authentication/login-as-helpers';
+
+describe('Petition generation - step 3', () => {
+  const VALID_FILE = '../../helpers/file/sample.pdf';
+
+  beforeEach(() => {
+    loginAsPetitioner();
+    cy.visit('/file-a-petition/new');
+    fillPetitionerInformation();
+    fillPetitionFileInformation(VALID_FILE);
+  });
+
+  it('IRS Notice Provided: should be free of a11y issues', () => {
+    cy.get('[data-testid="irs-notice-Yes"]').click();
+    checkA11y();
+  });
+
+  it('IRS Notice not Provided: should be free of a11y issues', () => {
+    cy.get('[data-testid="irs-notice-No"]').click();
+    checkA11y();
+  });
+});

cypress/local-only/tests/accessibility/petitionGeneration/petition-generation-step-4.cy.ts

@@ -0,0 +1,28 @@
+import { checkA11y } from '../../../support/generalCommands/checkA11y';
+import {
+  fillIrsNoticeInformation,
+  fillPetitionFileInformation,
+  fillPetitionerInformation,
+} from '../../integration/fileAPetitionUpdated/petition-helper';
+import { loginAsPetitioner } from '../../../../helpers/authentication/login-as-helpers';
+
+describe('Petition generation - step 4', () => {
+  const VALID_FILE = '../../helpers/file/sample.pdf';
+
+  beforeEach(() => {
+    loginAsPetitioner();
+    cy.visit('/file-a-petition/new');
+    fillPetitionerInformation();
+    fillPetitionFileInformation(VALID_FILE);
+    fillIrsNoticeInformation(VALID_FILE);
+  });
+
+  it('Regular Case: should be free of a11y issues', () => {
+    checkA11y();
+  });
+
+  it('Small Case: should be free of a11y issues', () => {
+    cy.get('[data-testid="procedure-type-1"]').click();
+    checkA11y();
+  });
+});