10455-story: remove duplicative sendEmail

ustaxcourt · Sep 5, 2024 · 301bbd3 · 301bbd3
1 parent b7d6db1
commit 301bbd3
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 19 deletions.
diff --git a/scripts/user/add-judge.ts b/scripts/user/add-judge.ts
@@ -18,7 +18,6 @@ import {
   getUserPoolId,
   requireEnvVars,
 } from '../../shared/admin-tools/util';
-import { sendWelcomeEmail } from 'scripts/user/email-helpers';
 
 // eslint-disable-next-line spellcheck/spell-checker
 /**
@@ -115,9 +114,6 @@ requireEnvVars(['ENV']);
     user: rawUser,
   });
 
-  console.log('Sending welcome email ... ');
-  await sendWelcomeEmail({ applicationContext, email });
-
   console.log(
     `\nSuccess! Created Judge ${judgeFullName} with userId = ${userId} and email = ${email}.`,
   );

diff --git a/scripts/user/add-user.ts b/scripts/user/add-user.ts
@@ -9,7 +9,6 @@ import {
 } from '../../shared/admin-tools/util';
 import { judgeUser } from '@shared/test/mockUsers';
 import { mockJudgeUser } from '@shared/test/mockAuthUsers';
-import { sendWelcomeEmail } from 'scripts/user/email-helpers';
 import joi from 'joi';
 
 requireEnvVars(['ENV', 'DEFAULT_ACCOUNT_PASS']);
@@ -104,6 +103,18 @@ const checkParams = ({
   return value;
 };
 
+export const sendWelcomeEmail = async ({ email }) => {
+  try {
+    await applicationContext.getCognito().adminCreateUser({
+      MessageAction: 'RESEND',
+      UserPoolId: environment.userPoolId,
+      Username: email.toLowerCase(),
+    });
+  } catch (err) {
+    console.error('Error sending welcome email', err);
+  }
+};
+
 // eslint-disable-next-line @typescript-eslint/no-floating-promises
 (async () => {
   const { tableName } = await getDestinationTableInfo();
@@ -130,5 +141,5 @@ const checkParams = ({
     setPasswordAsPermanent: true,
     user: { ...params },
   });
-  await sendWelcomeEmail({ applicationContext, email: params.email });
+  await sendWelcomeEmail({ email: params.email });
 })();
diff --git a/scripts/user/email-helpers.ts b/scripts/user/email-helpers.ts