Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed Forensics banner pop up and fixed unit test #343

Open
wants to merge 1 commit into
base: integration
Choose a base branch
from

Conversation

chuanlin2018
Copy link
Collaborator

https://sgitlab.nist.gov/oar-odd/landing-page-service/-/issues/10
Issue: Forensics image banner flashed before CHIPS banner showed up for when semiconductors page started up.
Solution: Changed the default image URL from "Forensics" to blank.

It's difficult to test it locally because the page is loaded too fast. Need to test it in oardev.

@chuanlin2018 chuanlin2018 requested a review from RayPlante July 30, 2024 19:52
Base automatically changed from feature/semiconductors02 to integration September 10, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant