Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(docker): allow composer to run as root #4996

Merged
merged 4 commits into from
Oct 7, 2024
Merged

chore(docker): allow composer to run as root #4996

merged 4 commits into from
Oct 7, 2024

Conversation

tuxpiper
Copy link
Member

@tuxpiper tuxpiper commented Oct 1, 2024

This pull request makes the following changes:

  • Our containers are set up to run as root and composer expects this environment variable to be set up in that case

Test checklist:

  • [ ]

  • I certify that I ran my checklist

Fixes ushahidi/platform# .

Ping @ushahidi/platform

@tuxpiper tuxpiper requested a review from ushahidlee October 1, 2024 08:11
ushahidlee
ushahidlee approved these changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@ushahidlee ushahidlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An elegant solution 👍

@tuxpiper tuxpiper merged commit a440fd3 into develop Oct 7, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ushahidlee ushahidlee ushahidlee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tuxpiper @ushahidlee