Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/ush 1018 #4675

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Hotfix/ush 1018 #4675

merged 1 commit into from
Nov 30, 2023

Conversation

webong
Copy link
Contributor

@webong webong commented Nov 30, 2023

This pull request makes the following changes:

  • In the V5 Config Handler, use laravel config helper to read default settings value

Fixes USH-1018

Ping @ushahidi/platform

Copy link

linear bot commented Nov 30, 2023

USH-1018 Production deployment missing config.data-provider rows

After following up on Intercom report: https://app.intercom.com/a/inbox/hl5rfiga/inbox/admin/5846639/conversation/27442012891?view=List

I noticed that

https://military-ru.api.ushahidi.io/api/v5/config

was raising a 500 error, with details seen here:
https://ushahidi.sentry.io/issues/4618342892/?project=88058&query=is%3Aunresolved&referrer=issue-stream&stream_index=0

For some unknown reason data-provider entries in the config table were missing. I have added them manually to that deployment.

image.png

The problem is: this shouldn't have happened. Config entries shouldn't disappear like that.

The problem is: the backend code is expecting those rows to be present in the config table, whereas they weren't necessary before

@webong webong changed the base branch from develop to release/2023.46 November 30, 2023 11:32
@webong webong requested a review from Mh-Asmi November 30, 2023 11:32
Copy link
Contributor

@Mh-Asmi Mh-Asmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is good for me and forth x the issue, but I didn't check it on my local as I'm outside.
@webong please confirm that it is fixed by checking your local laravel log doesn't have this error log

@tuxpiper tuxpiper merged commit 0255d17 into release/2023.46 Nov 30, 2023
4 checks passed
@webong
Copy link
Contributor Author

webong commented Nov 30, 2023

The code is good for me and forth x the issue, but I didn't check it on my local as I'm outside. @webong please confirm that it is fixed by checking your local laravel log doesn't have this error log

Yes, I can confirm reproduction of the error and that thie hotfix has been tested locally and it works fine.

@Mh-Asmi Mh-Asmi deleted the hotfix/USH-1018 branch January 21, 2025 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants