Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update V3 Module ServiceProvider & App UserCreateCommand.php #4665

Merged
merged 2 commits into from
Nov 9, 2023
Merged

Update V3 Module ServiceProvider & App UserCreateCommand.php #4665

merged 2 commits into from
Nov 9, 2023
+10 −10

Conversation

webong
Copy link
Contributor

@webong webong commented Nov 9, 2023 •
edited
Loading

This pull request makes the following changes:

  • Bind the right TosServiceProvider class
  • Arrange the class imports in the V3 Module ServiceProvider
  • Update the UserCreateCommand class to handle validation properly

Ping @ushahidi/platform

@webong webong changed the title Update V3 Module ServiceProvider.php Update V3 Module ServiceProvider & App UserCreateCommand.php Nov 9, 2023
@webong webong requested a review from tuxpiper November 9, 2023 11:05
tuxpiper
tuxpiper approved these changes Nov 9, 2023
View reviewed changes
Copy link
Member

@tuxpiper tuxpiper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tuxpiper tuxpiper merged commit 779251b into release/2023.42 Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuxpiper tuxpiper

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@webong @tuxpiper