Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

close notifications after a set timeut of 6s or when user navigates f… #1777

Merged
merged 4 commits into from
Apr 25, 2022

Conversation

helen-ndip
Copy link
Contributor

…rom a page

This pull request makes the following changes:

Testing checklist:

  • automatically dismiss notification when user navigates away from a page.
  • automatically dismiss notification after 6s if user decides to stay on a page.
  • I certify that I ran my checklist

Fixes ushahidi/platform#4384.

Ping @ushahidi/platform

@Angamanga Angamanga self-requested a review April 4, 2022 09:52
Copy link
Collaborator

@Angamanga Angamanga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution @helen-ndip! I like the solution but I would like to remove the timeout and only keep closing it for navigation-changes. For some of the notifications, the slider actually needs to be open to prevent the user from missing it, for example csv exports so its actually better to keep it.

@helen-ndip
Copy link
Contributor Author

Thank you for your contribution @helen-ndip! I like the solution but I would like to remove the timeout and only keep closing it for navigation-changes. For some of the notifications, the slider actually needs to be open to prevent the user from missing it, for example csv exports so its actually better to keep it.

I think so too. I will update that right away.

@helen-ndip
Copy link
Contributor Author

@Angamanga I have done the suggested changes.

@helen-ndip
Copy link
Contributor Author

Thank you for your contribution @helen-ndip! I like the solution but I would like to remove the timeout and only keep closing it for navigation-changes. For some of the notifications, the slider actually needs to be open to prevent the user from missing it, for example csv exports so its actually better to keep it.

@Angamanga do I still need to make some more changes? I think I am done with this

Copy link
Collaborator

@Angamanga Angamanga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution 🙏 Approved!

@Angamanga
Copy link
Collaborator

@Obadha2 Ready for QA.

@AmTryingMyBest AmTryingMyBest merged commit 9480e8e into ushahidi:develop Apr 25, 2022
@AmTryingMyBest
Copy link
Contributor

@Angamanga QA'd, passes. 👍

@Angamanga
Copy link
Collaborator

Angamanga commented Apr 28, 2022

@tuxpiper To include in next release!

@tuxpiper
Copy link
Member

Wonderful 👌, thank you all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dismiss the error message notification/footer that appears on submitting survey.
4 participants