-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
close notifications after a set timeut of 6s or when user navigates f… #1777
close notifications after a set timeut of 6s or when user navigates f… #1777
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution @helen-ndip! I like the solution but I would like to remove the timeout and only keep closing it for navigation-changes. For some of the notifications, the slider actually needs to be open to prevent the user from missing it, for example csv exports so its actually better to keep it.
I think so too. I will update that right away. |
@Angamanga I have done the suggested changes. |
@Angamanga do I still need to make some more changes? I think I am done with this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution 🙏 Approved!
@Obadha2 Ready for QA. |
@Angamanga QA'd, passes. 👍 |
@tuxpiper To include in next release! |
Wonderful 👌, thank you all! |
…rom a page
This pull request makes the following changes:
Testing checklist:
Fixes ushahidi/platform#4384.
Ping @ushahidi/platform