Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Outreachy Task Submission] Add Unique and Simple Titles to Every Page #991

Conversation

Chiemezuo
Copy link
Contributor

Introduction

This fixes #4909. It adds a unique and simple title to each page, instead of the generic "Localhost:4200" when running locally, or the site deployment name when on web.

How to Test this PR

  1. Login to your running Ushahidi deployment (preferably on the web).
  2. Navigate to the pages on the platform and look at the titles that show in your browser tab.
  3. For the web, notice how all titles are the same as the site deployment name. For local deployments, you will notice it's all Localhost.
  4. Checkout to this PR.
  5. Repeat steps 1 and 2.
  6. You will notice that now, the titles are specific to each route, and they get their name from the URL.

Video Reference

Here's a video of what it looks like before this PR. Note the top part of the browser that shows the tab.

Before.title.fix.mp4

Here's a video of what it looks like after this PR. Note the top part of the browser that shows the tab.

After.title.fix.mp4

@MugoBrian
Copy link
Contributor

Hello @Chiemezuo. Nice catch! It would be better if the page title would read [Deployment Name] | [Route Name] e.g Mzima Ushahidi | Activity. Or what's your take on this?

@Chiemezuo
Copy link
Contributor Author

@MugoBrian It could go either way. Some sites use just the routes as the titles, some use the routes in combination with the name of the website. It's something the team would have to agree on.
This PR is just a way of saying "for a start, this is possible."

@MugoBrian
Copy link
Contributor

I get it now. Thank you.

@Chiemezuo
Copy link
Contributor Author

You're welcome.

Copy link
Member

@tuxpiper tuxpiper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice contribution! I think this would need some product review before merging, possibly some tweaks to the specs as indeed the titles themselves may need to be different. But the work is nice. 👍

cc: @Timonize please check out this contribution

@Chiemezuo
Copy link
Contributor Author

Thank you!! @tuxpiper
I believe it does need some tweaks as well. Looking forward to more feedback.

@Angamanga Angamanga closed this Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Outreachy Task Submission] Accessibility Issue with Page Titles
4 participants