Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Outreachy Task Submission ] The HTML-embedded icon for copying does not gain focus when navigating through tabs using the keyboard in the Share Deployment Modal. #989

Closed
wants to merge 2 commits into from
Closed

[Outreachy Task Submission ] The HTML-embedded icon for copying does not gain focus when navigating through tabs using the keyboard in the Share Deployment Modal. #989

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c7e8fad
Copy button is focusable, added some margin to the share social icons…
MugoBrian Mar 30, 2024
f76bf18
The mzima-client-button is now clickable via keyboard enter, added a …
MugoBrian Mar 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions apps/web-mzima-client/src/app/shared/components/share-modal/share-modal.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,11 +41,16 @@
[(ngModel)]="htmlEmbed"
>
</textarea>
<mat-icon
(click)="copyToClipboard()"
<mzima-client-button
fill="outline"
color="transparent-style-1"
[iconOnly]="true"
class="fab-button__icon copy"
svgIcon="copy"
></mat-icon>
[ariaLabel]="'Copy HTML' | translate"
(click)="copyToClipboard()"
>
<mat-icon svgIcon="copy"></mat-icon>
</mzima-client-button>
</mat-form-field>
</div>
</div>
Expand Down
19 changes: 17 additions & 2 deletions apps/web-mzima-client/src/app/shared/components/share-modal/share-modal.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,26 @@

.copy {
position: absolute;
inset-inline-end: 16px;
inset-inline-end: 4px;
top: 50%;
transform: translate(0, -50%);
cursor: pointer;

::ng-deep {
.mzima-button {
&--outline {
--background-color: var(--color-neutral-70);
--hover-background-color: var(--color-neutral-10);
--active-background-color: var(--color-neutral-20);
}

&--icon-only {
width: var(--size, 36px);
height: var(--size, 36px);
font-size: var(--icon-size, 24px);
}
}
}
&-success {
position: absolute;
width: 100%;
Expand Down Expand Up @@ -52,7 +67,7 @@
justify-content: space-between;

mzima-client-button {
margin: 0 8px 8px;
margin: 0 8px 12px;
width: calc(50% - 16px);
}
}
Expand Down
Loading