[Outreachy Task Submission] - Added confirmation messages and a complete button when posts are added to collections #888
Conversation
… a done button for better user interactivity
… a done button for better user interactivity
There was a problem hiding this comment.
Thank you for your contributions, this is a very needed addition :) I have a few change requests, see my comments in the code.
Is there any specific reason you created the alert-service? You can look at https://github.com/ushahidi/platform-client-mzima/blob/development/apps/web-mzima-client/src/app/post/post-edit/post-edit.component.ts#L640 to see how the message is displayed when successfully adding a post. Maybe you can use something from there to show the message directly without having to go via the alert-service :)
| @@ -113,25 +113,69 @@ export class GeneralComponent implements OnInit { | |||
| .pipe( | |||
| mergeMap((newImage: any) => { | |||
| this.siteConfig.image_header = newImage.result.original_file_url; | |||
| console.log(newImage.result.original_file_url); | |||
| console.log(this.updateSettings()); | |||
| return this.updateSettings(); | |||
There was a problem hiding this comment.
Remove the console.logs here
There was a problem hiding this comment.
Is the changes in this file part of this PR? If not, remove the commits to only include changes for the specific issue you are solving :)
There was a problem hiding this comment.
Is the changes in this file part of this PR? If not, remove the commits to only include changes for the specific issue you are solving :)
This PR fixes the issue raised here - ushahidi/platform#4830 @Angamanga
When a post is added or removed from a collection, there is no confirmation message for this processes. Also after selecting a collection, there is no done or finish button for better user interactivity.
Steps to reproduce;
Actual Behaviour
A collection modal pops up, select your collection and no confirmation message or a done button
Expected Behaviour;
There should be a snackbar notification showing the success of adding or removing a post from a collection.
What I did;
I added confirmation messages to show when a post is added or removed from a collection -including the collection name
I added a done button for better user interactivity and accessibility. Below are the screenshots to show