Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ush 1299 - Upgrade to Capacitor 6 (Android 14) #1184

Merged
merged 2 commits into from
Aug 14, 2024
Merged

Conversation

ushahidlee
Copy link
Contributor

Issue:

The google play store requires a minimum SDK version of 34 (Android 14) from August 31.

Solution:

To achieve this minimum, we have to upgrade Capacitor to version 6. Also, Android 14 does not require the camera to check for permissions before use (and Capacitor/Camera currently has a bug where this blocks app execution ionic-team/capacitor-plugins#2140)

Testing:

As this is a major upgrade of dependencies, both builds of the app will need to be tested (iOS and Android) across all functionality with special focus on native functions:

  • Camera use
  • Keyboard use
  • Sharing

@ushahidlee ushahidlee requested a review from Angamanga August 13, 2024 04:36
@Angamanga
Copy link
Contributor

Looks good. I tested on iOS only and everything seems to be working as it should there. My Android-phone is hiding so could not double-check there right now.

Copy link
Contributor

@Angamanga Angamanga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📱 ☎️ All good!

@ushahidlee ushahidlee merged commit 0540104 into development Aug 14, 2024
12 checks passed
tuxpiper pushed a commit that referenced this pull request Oct 1, 2024
* Capacitor 6

* Fix for capacitor camera bug
ushahidlee added a commit that referenced this pull request Oct 9, 2024
* Capacitor 6

* Fix for capacitor camera bug
tuxpiper pushed a commit that referenced this pull request Dec 10, 2024
* Capacitor 6

* Fix for capacitor camera bug
tuxpiper pushed a commit that referenced this pull request Jan 28, 2025
* Capacitor 6

* Fix for capacitor camera bug
tuxpiper pushed a commit that referenced this pull request Feb 18, 2025
* Capacitor 6

* Fix for capacitor camera bug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants