-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed XZ compression feature of serialized IValues #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavyLandman
force-pushed
the
remove-xz-dependency
branch
from
April 3, 2024 09:04
00d9067
to
060b304
Compare
jurgenvinju
reviewed
Apr 3, 2024
src/main/java/io/usethesource/vallang/io/binary/stream/Compressor.java
Outdated
Show resolved
Hide resolved
jurgenvinju
reviewed
Apr 3, 2024
src/main/java/io/usethesource/vallang/io/binary/stream/Compressor.java
Outdated
Show resolved
Hide resolved
jurgenvinju
reviewed
Apr 3, 2024
src/main/java/io/usethesource/vallang/io/binary/stream/Header.java
Outdated
Show resolved
Hide resolved
jurgenvinju
reviewed
Apr 3, 2024
src/main/java/io/usethesource/vallang/io/binary/stream/IValueInputStream.java
Outdated
Show resolved
Hide resolved
jurgenvinju
reviewed
Apr 3, 2024
src/main/java/io/usethesource/vallang/io/binary/stream/IValueOutputStream.java
Show resolved
Hide resolved
jurgenvinju
requested changes
Apr 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice to get this over with!
@jurgenvinju thanks, done, squash & merge when approved :) |
DavyLandman
force-pushed
the
remove-xz-dependency
branch
from
April 3, 2024 12:11
a806889
to
0c4c69b
Compare
jurgenvinju
approved these changes
Apr 9, 2024
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #252