Bump the upstream-libs group with 1 update #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps the upstream-libs group with 1 update: [com.github.luben:zstd-jni](https://github.com/luben/zstd-jni). Updates `com.github.luben:zstd-jni` from 1.5.5-11 to 1.5.6-1 - [Commits](luben/zstd-jni@v1.5.5-11...v1.5.6-1) --- updated-dependencies: - dependency-name: com.github.luben:zstd-jni dependency-type: direct:production update-type: version-update:semver-patch dependency-group: upstream-libs ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
added
dependencies
|
We need some scrutiny here. Given the complex coordinated attack on XZ this week, it's prudent to not update such dependencies without vetting them thoroughly and with a little patience. Since rascal releases are coming quickly after each other these days, and we are deploying fat jars with these dependencies included, we also need to be extra careful. |
|
Let's not merge this for now. |
|
This is not xz, this is zstd ;) Also, what makes us say that the previous zstd version is the correct one to keep? (and zstd did not have the whole lonely maintainer problem, it's backed by facebook for quite a while now) |
|
Talked with @DavyLandman and we decided the risk is acceptible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps the upstream-libs group with 1 update: com.github.luben:zstd-jni.
Updates
com.github.luben:zstd-jnifrom 1.5.5-11 to 1.5.6-1Commits
77e74a7Fix registerSequenceProducer and re-enable to Sequence API355e64aImport v1.5.6 sourcesc66db1eFix9c75768Fix test26ad7edZstdInputStreamNoFinalizer / ZstdOutputStreamNoFinalizer may leak buffers whe...20014d1README: Move local dependency note above build step and add command linec776e15Use atomic flag if the native library is loaded or notDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditions