Fix bug where a large file (>1GiB) would cause a int overflow #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reasons was to avoid large buffers getting allocated for small files, but that hurt big files in the end
DavyLandman
changed the title
jurgenvinju
reviewed
Feb 14, 2024
src/main/java/io/usethesource/vallang/io/binary/util/DirectZstdInputStream.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reasons was to avoid large buffers getting allocated for small files, but that hurt big files in the end.
It was only triggered with files bigger than
(1<<31)/2. So any file bigger than 1073741824 bytes, or 1024 MiB, aka 1 GiB