Test support for error recovery #2034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great tests 👍 good initial results as well :) |
DavyLandman
approved these changes
Oct 2, 2024
src/org/rascalmpl/library/lang/rascal/tests/concrete/recovery/RecoveryTestSupport.rsc
Outdated
Show resolved
Hide resolved
toinehartman
pushed a commit
that referenced
this pull request
Oct 16, 2024
Test support for error recovery
toinehartman
pushed a commit
that referenced
this pull request
Oct 21, 2024
Test support for error recovery
toinehartman
pushed a commit
that referenced
this pull request
Oct 21, 2024
Test support for error recovery
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To gain confidence in our error recovery approach and to be able to measure progress in the quality of error recovery, this PR adds support for testing error recovery.
At this point we only test for "single character deletion" and "delete to end-of-line" errors.
This PR also optimizes
defaultErrorDisambiguationFilterbut even after this optimization it still has a time complexity problem: it runs inO(n^2), with n the number of nodes in the parse forest. We will tackle this issue in an upcoming PR.