Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework maven code for faster calculation of path config #1661

Open
wants to merge 19 commits into
base: main
Choose a base branch
from

Conversation

DavyLandman
Copy link
Member

@DavyLandman DavyLandman commented Oct 3, 2022

This needs effort to make this work together with our shaded jars.

@codecov
Copy link

codecov bot commented Oct 3, 2022

Codecov Report

Attention: Patch coverage is 69.04762% with 13 lines in your changes missing coverage. Please review.

Project coverage is 49%. Comparing base (0a7dcdb) to head (badd6e0).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
src/org/rascalmpl/library/util/PathConfig.java 38% 8 Missing ⚠️
src/org/rascalmpl/library/util/Maven.java 82% 3 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              main   #1661   +/-   ##
=======================================
- Coverage       49%     49%   -1%     
+ Complexity    6312    6288   -24     
=======================================
  Files          664     665    +1     
  Lines        59626   59635    +9     
  Branches      8646    8647    +1     
=======================================
- Hits         29490   29452   -38     
- Misses       27924   27970   +46     
- Partials      2212    2213    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

On windows increases speed from 14s to 2s
…y, changing output streams, hoping it's not a race)
@jurgenvinju
Copy link
Member

The idea would be to turn this PR into a general utility/service for Maven-related features for Rascal:

  • dependency resolution
  • exploration and install of new components in the REPL/IDE

Davy's setup allows for a lean and fast application of maven features.

@rodinaarssen rodinaarssen marked this pull request as ready for review August 27, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants