Support has in rename refactoring
#495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rascal-lsp/src/main/java/org/rascalmpl/vscode/lsp/rascal/RascalTextDocumentService.java
Show resolved
Hide resolved
toinehartman
force-pushed
the
feature/rename-refactoring/has
branch
from
63dba6b
to
ebdf1f7
Compare
DavyLandman
reviewed
Nov 6, 2024
rascal-lsp/src/main/java/org/rascalmpl/vscode/lsp/rascal/RascalLanguageServices.java
Outdated
Show resolved
Hide resolved
DavyLandman
reviewed
Nov 6, 2024
DavyLandman
reviewed
Nov 6, 2024
rascal-lsp/src/main/rascal/lang/rascal/lsp/refactor/WorkspaceInfo.rsc
Outdated
Show resolved
Hide resolved
DavyLandman
reviewed
Nov 6, 2024
rascal-lsp/src/main/rascal/lang/rascal/lsp/refactor/WorkspaceInfo.rsc
Outdated
Show resolved
Hide resolved
DavyLandman
approved these changes
Nov 6, 2024
DavyLandman
approved these changes
Nov 8, 2024
rascal-lsp/src/main/rascal/lang/rascal/lsp/refactor/WorkspaceInfo.rsc
Outdated
Show resolved
Hide resolved
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements support for renaming field names used in
<Expression> has <Name>. Since this uses a dynamic check and the name is not statically resolved to any definition, this requires user interaction to preserve semantics.This PR also adds framework support user-confirmable rename suggestions.