-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename refactoring for grammars #418
Conversation
bc2970e
to
e0b7c41
Compare
rascal-lsp/src/main/rascal/lang/rascal/tests/rename/Grammars.rsc
Outdated
Show resolved
Hide resolved
…-module' into feature/rename-refactoring/grammars
e0b7c41
to
91a1c75
Compare
a735cbe
to
cf68cfd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be valuable to add a paragraph on when certain definitions are merged and when they're not. It is implied by the the "module structure" tests (of which only some have documentation as to what a <X>
module structure is).
All in all: LGTM!
rascal-lsp/src/main/rascal/lang/rascal/tests/rename/Grammars.rsc
Outdated
Show resolved
Hide resolved
h/t @rodinaarssen Co-authored-by: Rodin Aarssen <[email protected]>
515cdd3
to
825d30c
Compare
Quality Gate passedIssues Measures |
Implements grammar support for the rename refactoring.
Complementary to #397. Allows renaming of productions, constructors, fields/labels in grammars.