This repository has been archived by the owner on Jul 25, 2019. It is now read-only.
Proxy Awareness #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expose the "Proxy" property from RestSharp's "RestClient" class. Allow this to be passed via the "Client" constructor. This will enable proxy configuration for the UserVoice client.
|
Is this project still active? Noticed that there has been no activity for some time... |
|
This project is definitely still alive, but it's small and feature-complete. It sounds like you know exactly what you want to do, if you can submit a pull request we can get it merged. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the client does not appear to expose any settings for proxy environments. As a result, this means that communication with UserVoice within such an environment does not always work (for example, where outbound internet access is prohibited unless going through the proxy).
RestSharp does have proxy settings available, however the Client class is not currently exposing these. I propose exposing the relevant proxy properties from the RestSharp client class so that proxy connection settings can be configured as required.