Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'architecture' label not required for input to atomic-reactor #78

Open
twaugh opened this issue Apr 10, 2018 · 1 comment
Open

'architecture' label not required for input to atomic-reactor #78

twaugh opened this issue Apr 10, 2018 · 1 comment

Comments

@twaugh
Copy link

twaugh commented Apr 10, 2018

Red Hat and Fedora container images are built using atomic-reactor, and while the 'architecture' label is required to be present in the built images, in fact it is added automatically by atomic-reactor.

In other words, the Dockerfile in the git repository serves as input to atomic-reactor, which adds a set of labels before building. 'architecture' is one of those labels.

I'd suggest removing the requirement to have 'architecture' present in the Dockerfile for Red Hat and Fedora container images.

@lachmanfrantisek
Copy link
Member

The dockerfile checks are not ready yet, but you are right -- we should differentiate checks for the image/container and the Dockerfile. (Since we decided to check the automatically added labels as well.)

Thank you for pointing it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants