Sharing label definitions

[lachmanfrantisek]

We need to provide the solution allowing:

• Have one definition for one label (description, links, ..)
• Allow using the same definition for the image, container and dockerfile
• Allow specifying target type for the check in ruleset JSON.

Related to #78

---

When we are in changing of the ruleset file structure, what about some metadata/versioning.
(Or move check groups from the root level to be able to extend the scheme.)

[lachmanfrantisek]

First approach

• Encapsulate filtered checks into the dictionary:

{
  "labels": {
    "required": [
      "name",
      "release_capital_deprecated",
      {
        "type": [
          "Container",
          "Image"
        ],
        "checks": [
          "architecture",
          "com_redhat_build-host",
          "authoritative-source-url",
          "vendor",
          "release",
          "url",
          "build-date",
          "distribution-scope",
          "vcs-ref",
          "vcs-type"
        ]
      }
    ],
    "optional": [
    ]
  },
  "best_practices": {
    "required": [
      "help_file",
      "cmd_or_entrypoint",
      "no_root"
    ],
    "optional": [
    ]
  }
}

[lachmanfrantisek]

Second approach

• Specify type per check

{
  "labels": {
    "required": [
      "name",
      "release_capital_deprecated",
      {
        "name": "architecture",
        "type": [
          "Container",
          "Image"
        ]
      },
      {
        "name": "com_redhat_build-host",
        "type": [
          "Container",
          "Image"
        ]
      }
    ],
    "optional": [
    ]
  },
  "best_practices": {
    "required": [
      "help_file",
      "cmd_or_entrypoint",
      "no_root"
    ],
    "optional": [
    ]
  }
}

[TomasTomecek]

I like the first approach.

[phracek]

First approach looks better but what do you think about this:

{
  "labels": {
    "required": [
      "name",
      "release_capital_deprecated",
      "architecture": { "type": [ "Container", "Image" ] }
      "com_redhat_build-host" : {  "type": [ "Container", "Image" ] }
    ],
    "optional": [
    ]
  },
  "best_practices": {
    "required": [
      "help_file",
      "cmd_or_entrypoint",
      "no_root"
    ],
    "optional": [
    ]
  }
}

[lachmanfrantisek]

@phracek Sadly, it's not a valid JSON.