Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symfony4 #4

Open
wants to merge 3 commits into
base: allow_symfony_3
Choose a base branch
from
Open

Symfony4 #4

wants to merge 3 commits into from

Conversation

JJuszczyk
Copy link

No description provided.

@JJuszczyk JJuszczyk requested a review from shieldo February 19, 2020 10:29
Copy link

@shieldo shieldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shieldo
Copy link

shieldo commented Feb 19, 2020

However, we might want to keep this branch, and not merge it to master

Also this branch should be based on allow_symfony_3, not master

@JJuszczyk JJuszczyk changed the base branch from master to allow_symfony_3 February 19, 2020 10:55
@JJuszczyk
Copy link
Author

Yea, I'm aware of that, also changed the branch base

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants