Feature/config ordering #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bomoko @CGoodwin90 could you take a look at this one when you get the chance, thanks! |
bomoko
reviewed
Aug 13, 2023
cmd/sync.go
Outdated
| @@ -170,6 +183,137 @@ func syncCommandRun(cmd *cobra.Command, args []string) { | |||
| } | |||
| } | |||
|
|
|||
| func createDefaultSyncherConfigRoot(syncerType string) synchers.SyncherConfigRoot { | |||
There was a problem hiding this comment.
I wanted to ask - this seems to duplicate, at least to some degree, the stuff we were doing in the "setDefaults" methods - why do we need to introduce this?
There was a problem hiding this comment.
Great spot - removed from here and keeping in defaults in synchers
There was a problem hiding this comment.
Seems this may have been added before since the setDefault was missing for mariabDb - added in here 3b1e3cc#diff-e878532b16029079651ee820572fb5de1dd16c3b02ba0a877c8c26403bac48e7R71-R72
added 2 commits
August 14, 2023 10:47
…itional to only update if extra config is found
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.