-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mkdocs init #89
base: main
Are you sure you want to change the base?
mkdocs init #89
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool. Let's go!
As long as the extensions and plugins are within the same set as the main lagoon repo - https://github.com/uselagoon/lagoon/blob/main/mkdocs.yml You can just reuse the github action there here https://github.com/uselagoon/lagoon/blob/main/.github/workflows/mkdocs.yml |
@tobybellwood just noticed this PR is here - is this still good to go? |
Locally, we can run `make release-test` to check if our changes will build. If compiling was successful we can commit our changes and then run `make release-[patch|minor|major]` to tag with next release number and it will push up to GitHub. A GitHub action will then be triggered which will publish the official release using goreleaser. | ||
|
||
Prior to that, we can locally test our release to ensure that it will successfully build with `make release-test`. If compiling was successful we can commit our changes and then run `make release-[patch|minor|major]` to tag with next release number and it will push up to GitHub. A GitHub action will then be triggered which will publish the official release using goreleaser. | ||
Locally whhen contributing, we can run `make release-test` to check if our changes will build sucessfully. If compiling was successful we can commit our changes to a new PR ready for review (https://github.com/uselagoon/lagoon-sync/pulls). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo :)
I'd say it might be worth checking locally again first... it's been a while :D |
No description provided.