Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mkdocs init #89

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

mkdocs init #89

wants to merge 2 commits into from

Conversation

timclifford
Copy link
Contributor

No description provided.

Copy link
Collaborator

@bomoko bomoko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool. Let's go!

@tobybellwood
Copy link
Member

As long as the extensions and plugins are within the same set as the main lagoon repo - https://github.com/uselagoon/lagoon/blob/main/mkdocs.yml

You can just reuse the github action there here https://github.com/uselagoon/lagoon/blob/main/.github/workflows/mkdocs.yml

@timclifford timclifford marked this pull request as ready for review September 4, 2023 11:23
@AlannaBurke
Copy link

@tobybellwood just noticed this PR is here - is this still good to go?

Locally, we can run `make release-test` to check if our changes will build. If compiling was successful we can commit our changes and then run `make release-[patch|minor|major]` to tag with next release number and it will push up to GitHub. A GitHub action will then be triggered which will publish the official release using goreleaser.

Prior to that, we can locally test our release to ensure that it will successfully build with `make release-test`. If compiling was successful we can commit our changes and then run `make release-[patch|minor|major]` to tag with next release number and it will push up to GitHub. A GitHub action will then be triggered which will publish the official release using goreleaser.
Locally whhen contributing, we can run `make release-test` to check if our changes will build sucessfully. If compiling was successful we can commit our changes to a new PR ready for review (https://github.com/uselagoon/lagoon-sync/pulls).
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo :)

@timclifford
Copy link
Contributor Author

@tobybellwood just noticed this PR is here - is this still good to go?

I'd say it might be worth checking locally again first... it's been a while :D

@tobybellwood tobybellwood self-assigned this Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants