Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrating SSH Portal config #81

Closed
wants to merge 12 commits into from
Closed

Integrating SSH Portal config #81

wants to merge 12 commits into from

Conversation

timclifford
Copy link
Contributor

No description provided.

@timclifford timclifford requested a review from bomoko November 8, 2022 16:44
@timclifford timclifford changed the title WIP: Integration SSH Portal config WIP: Integrating SSH Portal config Nov 8, 2022
bomoko
bomoko reviewed Nov 17, 2022
View reviewed changes
Copy link
Collaborator

@bomoko bomoko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Is there much else you need to add?

cmd/sync.go Show resolved Hide resolved
cmd/sync.go Outdated Show resolved Hide resolved
@timclifford timclifford changed the title WIP: Integrating SSH Portal config Integrating SSH Portal config Jul 24, 2023
@timclifford timclifford requested a review from bomoko July 24, 2023 14:56
@timclifford
Copy link
Contributor Author

timclifford commented Jul 31, 2023 •
edited
Loading

Tested various scenarios against test6 and test1 today. Be good to have someone else take a look too with a fresh pair for eyes.

timclifford
timclifford commented Aug 1, 2023
View reviewed changes
cmd/sync.go Show resolved Hide resolved
bomoko
bomoko requested changes Aug 10, 2023
View reviewed changes
cmd/sync.go Show resolved Hide resolved
cmd/sync.go Show resolved Hide resolved
tobybellwood
tobybellwood reviewed Aug 17, 2023
View reviewed changes
cmd/sync.go Outdated Show resolved Hide resolved
@timclifford timclifford requested a review from bomoko August 23, 2023 09:08
@timclifford timclifford mentioned this pull request Sep 6, 2023
Closed
@rocketeerbkw
Copy link
Member

I think this was done in #112

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bomoko bomoko Awaiting requested review from bomoko

@tobybellwood tobybellwood Awaiting requested review from tobybellwood

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@timclifford @rocketeerbkw @bomoko @tobybellwood