Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to hxr.admin-tools #998

Merged
merged 7 commits into from
Nov 20, 2023
Merged

Changes to hxr.admin-tools #998

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d3f3e3d
admin-tools, +defaults, -firawalld disable
mira-miracoli Nov 17, 2023
92b634b
fixed byobu conditional
mira-miracoli Nov 17, 2023
0c1a1d9
use elese
mira-miracoli Nov 17, 2023
ec6520b
filter still needed
mira-miracoli Nov 17, 2023
36c21f2
add quotes
mira-miracoli Nov 17, 2023
4a7306d
thanks José
mira-miracoli Nov 20, 2023
c0ed81f
Update roles/hxr.admin-tools/tasks/main.yml
mira-miracoli Nov 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions roles/hxr.admin-tools/vars/main.yml → roles/hxr.admin-tools/defaults/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,10 @@ admin_packages:
- net-tools
- unzip
- mutt
- byobu
- "{{ 'byobu' if ansible_distribution_major_version < '9' else default(omit) }}"
mira-miracoli marked this conversation as resolved.
Show resolved Hide resolved
- tmpwatch
- rclone
# centos specific
- setools-console
- yum-utils
- bind-utils

16 changes: 2 additions & 14 deletions roles/hxr.admin-tools/tasks/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,24 +1,12 @@
---
- name: Install useful tools
yum:
name: "{{ admin_packages }}"
name: "{{ admin_packages | select | list }}"
mira-miracoli marked this conversation as resolved.
Show resolved Hide resolved
state: installed

- name: Check if firewalld is already installed
yum:
list: firewalld
# If not installed yum_list.results[*].yumstate != installed
register: yum_list

- name: Stop firewalld
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fascinating, why would i do that?

I suspect it was because: internally we didn't strictly need a firewall, since a lot of that functionality was being provided in duplicate by OpenStack's firewall, and internally we did occasionally need random ports open for new services, but either way, that was some 🤠 nonsense, so, good that you add it back :)

service:
name: firewalld
state: stopped
enabled: no
when: yum_list.results | selectattr("yumstate", "match", "installed") | list | length != 0
Comment on lines -7 to -18
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This Role is used by:

  • telescope
  • apollo
  • build
  • plausible
  • cvmfs

Make sure that none of them assume that firewalld is disabled.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we do not want to disable firewalld anywhere.
since this is read only friday, I will not touch other roles today. We can let this unmerged for now

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I also think we do not want to disable firewalld anywhere. I am just commenting it so that we remember this.


- name: Start atop
service:
name: atop
state: started
enabled: yes
when: "'atop' in admin_packages"