Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

user specific notebooks #1370

Merged
merged 4 commits into from
Dec 8, 2024
Merged

user specific notebooks #1370

merged 4 commits into from
Dec 8, 2024

Conversation

bgruening
Copy link
Member

@sanjaysrikakulam @mira-miracoli do you think this will work?

Copy link
Member

@sanjaysrikakulam sanjaysrikakulam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should work, for reference.

However, I think the params, env, and even the scheduling tag might not be necessary as those will probably be merged from the IT tool spec of interactive_tool_jupyter_notebook in interactive_tools.yml and the rest from the destination.yml file (I think let's go with this for now, and when I get the time, I will double-check it on my test instance).

@bgruening
Copy link
Member Author

What do you think about adding this to my user? So I can test it ...?

@sanjaysrikakulam
Copy link
Member

What do you think about adding this to my user? So I can test it ...?

Sure! Let's do it in production! Why not....

@bgruening bgruening merged commit 717e6a6 into master Dec 8, 2024
4 checks passed
@bgruening bgruening deleted the user-specific-jupyter-roles branch December 8, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants