fix: create file field

usecollapsar · Nov 2, 2023 · 2707029 · 2707029
1 parent b3b96a3
commit 2707029
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 11 deletions.
diff --git a/makefile b/makefile
@@ -21,6 +21,7 @@ format: ## Format code with Black
 coverage: ## Run package tests and upload coverage reports
 	python -m pytest --cov-report term --cov-report xml --cov=src/collapsar tests
 publish: ## Publish package to pypi
+	npx vite build
 	python setup.py sdist bdist_wheel
 	twine upload --skip-existing dist/*
 	rm -fr build dist .egg src/collapsar.egg-info

diff --git a/setup.py b/setup.py
@@ -8,7 +8,7 @@
     # Versions should comply with PEP440.  For a discussion on single-sourcing
     # the version across setup.py and the project code, see
     # https://packaging.python.org/en/latest/single_source_version.html
-    version="0.0.12",
+    version="0.0.13",
     packages=[
         "collapsar",
         "collapsar.config",

diff --git a/src/collapsar/assets/js/components/fields/FileField.tsx b/src/collapsar/assets/js/components/fields/FileField.tsx
@@ -38,24 +38,26 @@ export function FileField(props: any) {
 
   return (
     <>
-      {props.value && !replaceImage ? (
+      {!replaceImage ? (
         <div>
           <Button
             type="button"
             variant="secondary"
             onClick={() => setReplaceImage(true)}
           >
-            Replace
+            {props.value ? "Replace" : "Set image"}
           </Button>
-          <img
+          {props.value && (
+            <img
             className="rounded-md border-2 mt-3 max-w-sm"
             src={`/${originalValue}`}
             alt=""
-          />
+            />
+          )}
         </div>
       ) : (
         <>
-          {props.value && (
+          {fileInput && (
             <div className="flex flex-col gap-3">
               <div className="flex gap-3">
                 <Button
@@ -67,19 +69,19 @@ export function FileField(props: any) {
                 </Button>
                 <Button
                   type="button"
-                  onClick={(e) => fileInput.current?.click()}
+                  onClick={(e) => fileInput?.current?.click()}
                 >
-                  {fileInput.current?.files?.length > 0 ? "Change selection" : "Select"}
+                  {fileInput?.current?.files?.length > 0 ? "Change selection" : "Select"}
                 </Button>
               </div>
-              {fileInput.current?.files?.length > 0 ? (
+              {fileInput?.current?.files?.length > 0 ? (
                 <div className="text-sm flex flex-col gap-3">
                   <div id="filename">
                     <div className="span">
-                      {fileInput.current.files[0].name}{" "}
+                      {fileInput?.current.files[0].name}{" "}
                     </div>
                     <span className="text-muted-foreground">
-                      {(fileInput.current.files[0].size / 1024).toFixed(1)} kb
+                      {(fileInput?.current.files[0].size / 1024).toFixed(1)} kb
                     </span>
                   </div>
                   <img