Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo, and fix type error #6

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

prestonButton
Copy link

@prestonButton prestonButton commented May 17, 2024

change 'additinoal' to 'additional' in docs, account page.

Fix type error that was preventing Vercel deployment of starter app.

./src/app/dashboard/(personalAccount)/settings/layout.tsx

On line 5:54: export default function PersonalAccountSettingsPage({children}) {

I was getting the error: Type error: Binding element 'children' implicitly has an 'any' type. when deploying to Vercel.

I changed to export default function PersonalAccountSettingsPage({children}: {children: React.ReactNode}) {

This resolved the error and Vercel build ran cleanly.

change additinoal to additional
Copy link

vercel bot commented May 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
basejump-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 17, 2024 10:05am

@prestonButton prestonButton changed the title Fix typo Fix typo, and fix type error May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant