Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing Limitation for Storage Size on Integration Testing for set_contract_storage() #1961

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Missing Limitation for Storage Size on Integration Testing for set_contract_storage() #1961

wants to merge 14 commits into from

Commits on Oct 30, 2023

  1. Add storage value size assertion

    @ramirez7358
    ramirez7358 committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    abbf40a View commit details
    Browse the repository at this point in the history

  2. Add integration test

    @ramirez7358
    ramirez7358 committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    18f3f85 View commit details
    Browse the repository at this point in the history

  3. Add changelog

    @ramirez7358
    ramirez7358 committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    cf463e5 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into set-contract-storage-integration-test-size… 

    …-validation
    @ramirez7358
    ramirez7358 authored Oct 30, 2023
    Configuration menu
    Copy the full SHA
    1110e01 View commit details
    Browse the repository at this point in the history

  5. Fix integration test

    @ramirez7358
    ramirez7358 committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    a5d0b5f View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2023

  1. Fix integration test

    @ramirez7358
    ramirez7358 committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    a74dae6 View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2023

  1. Updated unit tests to corrected set_contract_storage semantics

    @bramirezcf
    bramirezcf committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    27e671b View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2023

  1. Modified condition in set_contract_storage 

    Changed the limit to encoded_value.len() + encoded_key.len() > 2**14
    @faculerena
    faculerena committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    18d242c View commit details
    Browse the repository at this point in the history

  2. Added -4 in message and check, updated tests to reflect the change

    @faculerena
    faculerena committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    c585f0d View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2023

  1. Passed through cargofmt.

    @Helios-vmg
    Helios-vmg committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    c2df2d1 View commit details
    Browse the repository at this point in the history

  2. Fixed tests and storage. 

    try_insert() and try_set() were ignoring that insert() and set() increase the
length of the key by 4. After making the off-chain set_contract_storage()
respect the size limit, this was causing some tests to fail. The tests were
updated to test the correct limits.
    @Helios-vmg
    Helios-vmg committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    598cb04 View commit details
    Browse the repository at this point in the history

  3. Passed through cargofmt.

    @Helios-vmg
    Helios-vmg committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    7e1c3b6 View commit details
    Browse the repository at this point in the history

  4. Removed testing code.

    @Helios-vmg
    Helios-vmg committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    e8f4b9d View commit details
    Browse the repository at this point in the history

  5. Fixed up test.

    @Helios-vmg
    Helios-vmg committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    f86c010 View commit details
    Browse the repository at this point in the history