fix: prevents turning falsy values into null
#525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for contracts-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
peetzweg
changed the title
nullnull
Passing run #256 ↗︎
Details:
Review all test suite changes for PR #525 ↗︎ |
||||||||||||||||||||
pgherveou
approved these changes
Nov 20, 2023
peetzweg
deleted the
517-optionbool-does-not-work-when-value-is-false
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #517.
This function turned every js falsy value, like
false,"",0intonull, thereby preventing passing these actual values as inputs to contract calls.https://github.com/paritytech/contracts-ui/blob/2387223e1c9d5b0430831141862afea0e834382b/src/lib/callOptions.ts#L56-L70