Target pallet-revive/PolkaVM instead of pallet-contracts/Wasm
#1910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…default-to-revive
cmichi
changed the title
pallet-revivepallet-revive
cmichi
force-pushed
the
cmichi-remove-wasm-default-to-revive
branch
from
c98bd47 to
bfc62d9
Compare
cmichi
changed the title
pallet-revivepallet-revive/PolkaVM instead of pallet-contracts/Wasm
athei
reviewed
Feb 4, 2025
There was a problem hiding this comment.
You can get rid of this file and just use:
https://docs.rs/polkavm-linker/latest/polkavm_linker/fn.target_json_64_path.html
There was a problem hiding this comment.
@athei Thanks for the note! I saw your comment on another PR of mine on this file a while ago :-). Didn't forget, just didn't get around to it yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves
cargo-contractfrom compiling contracts to WebAssembly for Substrate'spallet-contractsmodule to compiling contracts to PolkaVM for Substrate'spallet-revivemodule.It's a big breaking change. With this PR we are moving towards the next major release of both ink! and
cargo-contract(version 6). From v6 on these tools which will no longer support Wasm/pallet-contracts.Compatibility
The PR uses the version of
polkadot-sdk(so alsopallet-revive) from commit645878a27115db52e5d63115699b4bbb89034067.It works with ink!
master(which at the time of writing is this commit) and this version ofsubstrate-contracts-node:Next Steps
The PR doesn't leave the code in a perfect state, there are still a lot of todo's in the code. I've disabled some individual tests for now, as they require more work. I'm merging the PR to have a base to work off and synchronize work with others.
The PR contains a lot of breaking changes that will eventually be documented in more verbatim form in the release notes and this migration guide.